Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-iot-actions): Add HTTPS action L2 Construct #25491

Closed
1 of 2 tasks
cponfick opened this issue May 9, 2023 · 2 comments · Fixed by #25535
Closed
1 of 2 tasks

(aws-iot-actions): Add HTTPS action L2 Construct #25491

cponfick opened this issue May 9, 2023 · 2 comments · Fixed by #25535
Labels
@aws-cdk/aws-iot-actions effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@cponfick
Copy link
Contributor

cponfick commented May 9, 2023

Describe the feature

Add a L2 construct for the https action.

Use Case

Create HTTPS actions, using L2 constructs.

Proposed Solution

Implement it similarly as the existing action constructs.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.78.0

Environment details (OS name and version, etc.)

macOS 13.3.1 (a)
@cponfick cponfick added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 9, 2023
@pahud
Copy link
Contributor

pahud commented May 9, 2023

Awesome! We'd love to review your PR when it's ready. Thank you.

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels May 9, 2023
@cponfick cponfick mentioned this issue May 11, 2023
Merged
@mergify mergify bot closed this as completed in #25535 Jul 13, 2023
mergify bot pushed a commit that referenced this issue Jul 13, 2023
@cponfick
feat(iot-actions): iot rule https action l2 construct (#25535)
3aee826 
Implemented the L2 construct for the IoT Core HTTPS action.


Closes #25491 .

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

colifran pushed a commit that referenced this issue Jul 17, 2023
@cponfick @colifran
feat(iot-actions): iot rule https action l2 construct (#25535)
a290d3b 
Implemented the L2 construct for the IoT Core HTTPS action.


Closes #25491 .

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this issue Jul 29, 2023
@cponfick @bmoffatt
feat(iot-actions): iot rule https action l2 construct (aws#25535)
0cac95a 
Implemented the L2 construct for the IoT Core HTTPS action.


Closes aws#25491 .

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-iot-actions effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(iot-actions): iot rule https action l2 construct
2 participants
@pahud @cponfick