Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codebuild: use custom arm linux image from external Docker registry #24367

Closed
2 tasks
viktorhaid opened this issue Feb 28, 2023 · 2 comments · Fixed by #26121
Closed
2 tasks

codebuild: use custom arm linux image from external Docker registry #24367

viktorhaid opened this issue Feb 28, 2023 · 2 comments · Fixed by #26121
Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@viktorhaid
Copy link

Describe the feature

Today you can use a custom x86 image from an external registry as a CodeBuild build image using the method codebuild.LinuxBuildImage.fromDockerRegistry.

But class LinuxArmBuildImage lacks this method.
It would be great if this class could also implement the method fromDockerRegistry, so we can use our own custom arm images, e.g.

const project = new codebuild.Project(this, 'MyProject', {
  environment: {
    buildImage: LinuxArmBuildImage.fromDockerRegistry('ghcr.io/...:latest'),
    computeType: codebuild.ComputeType.SMALL
  }
});

Use Case

I want to be able to use a custom arm linux image from external docker registry as a CodeBuild build image.

Both, the AWS Management Console and CloudFormation support it, but it is not possible when using CDK.

Currently we are stuck having to use Cloudformation for our arm compatible pipelines.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.66.0

Environment details (OS name and version, etc.)

Ubuntu 20.04.5 LTS

@viktorhaid viktorhaid added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 28, 2023
@github-actions github-actions bot added the @aws-cdk/aws-codebuild Related to AWS CodeBuild label Feb 28, 2023
@pahud
Copy link
Contributor

pahud commented Feb 28, 2023

Yeah I guess we can add this method to LinuxArmBuildImage. Any PR submission on this is more than welcome.

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Feb 28, 2023
@mergify mergify bot closed this as completed in #26121 Jul 18, 2023
mergify bot pushed a commit that referenced this issue Jul 18, 2023
)

Added support for usage of docker registry images when configuring CodeBuild Linux with ARM images

Closes #24367 and closes #24342

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this issue Jul 29, 2023
…#26121)

Added support for usage of docker registry images when configuring CodeBuild Linux with ARM images

Closes aws#24367 and closes aws#24342

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants