Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotswap + AppSync: Support for Hotswapping AppSync Pipeline Resolvers #24112

Open
2 tasks
alharris-at opened this issue Feb 10, 2023 · 0 comments
Open
2 tasks

Hotswap + AppSync: Support for Hotswapping AppSync Pipeline Resolvers #24112

alharris-at opened this issue Feb 10, 2023 · 0 comments
Labels
@aws-cdk/aws-appsync Related to AWS AppSync feature-request A feature should be added or improved. p3

Comments

@alharris-at
Copy link

alharris-at commented Feb 10, 2023 •
edited
Loading

Describe the feature

Today, AppSync Unit resolvers support hotswap, but Pipeline resolvers explicitly do not https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk/lib/api/hotswap/appsync-mapping-templates.ts#L16-L24

I'd like to understand a bit more about the limitations here, if we're not changing the functions within a pipeline, and just update the templates or code are we able to resolve the existing function ids when performing the swap (we're able to resolve the apiId today, so I'd think this is basically equivalent).

Use Case

I'd love to have a more fluid iteration experience while working on the business logic for my AppSync APIs.

I've written up a series of feature requests which I think will add to a faster, more fluid experience for AppSync users:

Proposed Solution

Support hotswapping templates and code in pipeline appsync resolvers.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.64.0

Environment details (OS name and version, etc.)

osx 13.2
@alharris-at alharris-at added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 10, 2023
@github-actions github-actions bot added the @aws-cdk/aws-appsync Related to AWS AppSync label Feb 10, 2023
This was referenced Feb 10, 2023
Open
Open
@pahud pahud added p2 and removed needs-triage This issue or PR still needs to be triaged. labels Feb 16, 2023
@Amplifiyer Amplifiyer mentioned this issue Sep 19, 2023
Merged
mergify bot pushed a commit that referenced this issue Sep 28, 2023
@Amplifiyer
feat(cdk): add AppSync GraphQLSchema and pipeline resolvers as hot sw…
0ea6313 
…appable (#27197)

1. Add GraphQLSchema as another AppSync resource that can be hotswapped
2. For all AppSync resources, accept the change in S3 assets/files instead of just inline code as a candidate for hotswap
3. Make pipeline resolvers hotswappable by resolving the functionId of AppSync functions.

Closes #2659, #24112, #24113.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@pahud pahud added p3 and removed p2 labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-appsync Related to AWS AppSync feature-request A feature should be added or improved. p3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pahud @alharris-at