Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iam] Support sts:ExternalId #235

Closed
rix0rrr opened this issue Jul 6, 2018 · 0 comments · Fixed by #1359
Closed

[iam] Support sts:ExternalId #235

rix0rrr opened this issue Jul 6, 2018 · 0 comments · Fixed by #1359
Assignees
@rix0rrr
Labels
feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Jul 6, 2018

Support request over email from Scott Brady.

Makes sense to add support for this--it's not entirely clear where yet.
@rix0rrr rix0rrr added the feature label Jul 6, 2018
@rix0rrr rix0rrr added the good first issue Related to contributions. See CONTRIBUTING.md label Sep 17, 2018
@rix0rrr rix0rrr added feature-request A feature should be added or improved. and removed feature-request A feature should be added or improved. feature labels Nov 6, 2018
@rix0rrr rix0rrr self-assigned this Dec 13, 2018
rix0rrr pushed a commit that referenced this issue Dec 13, 2018
feat(aws-iam): configure ExternalId for Role
ebaf45c 
Supply the `externalId` prop to add the appropriate
`{ StringEquals: { "sts:ExternalId": "...the id..." }}` to a
Role's `AssumeRolePolicyDocument`.

Fixes #235.
@rix0rrr rix0rrr mentioned this issue Dec 13, 2018
Merged
9 tasks
RomainMuller pushed a commit that referenced this issue Dec 14, 2018
@rix0rrr @RomainMuller
feat(aws-iam): configure ExternalId for Role (#1359)
3d200c9 
Supply the `externalId` prop to add the appropriate
`{ StringEquals: { "sts:ExternalId": "...the id..." }}` to a
Role's `AssumeRolePolicyDocument`.

Fixes #235.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(aws-iam): configure ExternalId for Role aws/aws-cdk
1 participant
@rix0rrr