-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
‼️ cli: @types/babel__traverse@7.18.3 breaks builds #23126
Labels
Comments
This was referenced Nov 28, 2022
mergify bot
pushed a commit
to projen/projen
that referenced
this issue
Nov 28, 2022
Related to aws/aws-cdk#23126 --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
mergify bot
pushed a commit
that referenced
this issue
Nov 28, 2022
…23125) Fixes the compile error when running `cdk init app --language typescript && npm run build`. Fixes: #23126 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
mrgrain
added a commit
that referenced
this issue
Nov 28, 2022
…23125) Fixes the compile error when running `cdk init app --language typescript && npm run build`. Fixes: #23126 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Nov 28, 2022
mergify bot
pushed a commit
that referenced
this issue
Nov 29, 2022
…3130) Fixes the compile error when running `cdk init app --language typescript && npm run build`. Fixes: #23126 for v1 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mrgrain
added a commit
that referenced
this issue
Nov 29, 2022
…3130) Fixes the compile error when running `cdk init app --language typescript && npm run build`. Fixes: #23126 for v1 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mrgrain
added a commit
to cdklabs/aws-cdk-notices
that referenced
this issue
Nov 30, 2022
mrgrain
added a commit
to cdklabs/aws-cdk-notices
that referenced
this issue
Nov 30, 2022
4 tasks
brennanho
pushed a commit
to brennanho/aws-cdk
that referenced
this issue
Dec 9, 2022
…ws#23125) Fixes the compile error when running `cdk init app --language typescript && npm run build`. Fixes: aws#23126 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
brennanho
pushed a commit
to brennanho/aws-cdk
that referenced
this issue
Jan 20, 2023
…ws#23125) Fixes the compile error when running `cdk init app --language typescript && npm run build`. Fixes: aws#23126 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
brennanho
pushed a commit
to brennanho/aws-cdk
that referenced
this issue
Feb 22, 2023
…ws#23125) Fixes the compile error when running `cdk init app --language typescript && npm run build`. Fixes: aws#23126 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Status: RESOLVED
Projects using TypeScript <4.2 (like the ones created with
cdk init
are failing to compile due to a transitive dependency introducing a breaking change. This issue does not affect you if you are using a recent TypeScript version.Possible Solutions
Any of the following options will work around this issue:
@types/babel__traverse
to7.18.2
indevDependencies
package.json
Upgrade the TypeScript version to TS
>=4.2
Create new apps with a AWS CDK CLI of version
>=2.52.1
or>=1.81.1
or projenDescribe the bug
A recent release of
@types/babel__traverse
(7.18.3) updated the minimum typescript version to4.2
. If you have CDK apps created withcdk init
and not upgraded the TypeScript version, the build will fail.Expected Behavior
No error.
Current Behavior
When trying to build a typescript app you get the error message:
Reproduction Steps
Step 1 - create a new CDK app
Step 2 - Try to build
Additional Information/Context
No response
CDK CLI Version
<=2.52.0
<=1.18.0
Framework Version
No response
Node.js Version
14+
OS
any
Language
Typescript
Language Version
<4.2
Other information
No response
The text was updated successfully, but these errors were encountered: