Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Stack.toCloudFormation @internal (and prefix with underscore) #2044

Closed
eladb opened this issue Mar 18, 2019 · 0 comments · Fixed by #2047 · May be fixed by MechanicalRock/account-reaper#6
Closed

Make Stack.toCloudFormation @internal (and prefix with underscore) #2044

eladb opened this issue Mar 18, 2019 · 0 comments · Fixed by #2047 · May be fixed by MechanicalRock/account-reaper#6

Comments

@eladb
Copy link
Contributor

eladb commented Mar 18, 2019

People should not call Stack.toCloudFormation(). Instead of should use app.synthesize() (which was actually deprecated and we should probably resurrect #2016)
@eladb eladb mentioned this issue Mar 18, 2019
Closed
eladb pushed a commit that referenced this issue Mar 18, 2019
refactor: name "toCloudFormation" internal (renamed to "_toCloudForma…
45cfdab 
…tion")

The method `toCloudFormation` is not supposed to be directly called by
users. Mark it as `@internal` and rename to `_toCloudFormation`.

Fixes #2044
Related #2016
@eladb eladb mentioned this issue Mar 19, 2019
Merged
4 tasks
eladb pushed a commit that referenced this issue Mar 19, 2019
refactor: name "toCloudFormation" internal (renamed to "_toCloudForma…
515868b 
…tion") (#2047)

The method `toCloudFormation` is not supposed to be directly called by
users. Mark it as `@internal` and rename to `_toCloudFormation`.

Fixes #2044
Related #2016

BREAKING CHANGE: “toCloudFormation” is now internal and should not be called directly. Instead use “app.synthesizeStack”
rix0rrr pushed a commit to alex-berger/aws-cdk that referenced this issue Mar 19, 2019
@rix0rrr
refactor: name "toCloudFormation" internal (renamed to "_toCloudForma…
5aa4fc7 
…tion") (aws#2047)

The method `toCloudFormation` is not supposed to be directly called by
users. Mark it as `@internal` and rename to `_toCloudFormation`.

Fixes aws#2044
Related aws#2016

BREAKING CHANGE: “toCloudFormation” is now internal and should not be called directly. Instead use “app.synthesizeStack”
This was referenced Dec 12, 2019
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@eladb