-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autoscaling for Fargate services does not support new ECS ARN format #1849
Autoscaling for Fargate services does not support new ECS ARN format #1849
Comments
Hi, we turned on the new ECS ARN format today and it has broken a number of our stacks. It would be great to see this fixed. |
Hi @pgarbe, Apologies about the delay in getting back to you. Was the error generated when you ran |
Hi @SoManyHs, after a bit of investigation this is actually a CloudFormation bug https://forums.aws.amazon.com/thread.jspa?threadID=294793 I’m not sure there is a work around that will work for both formats? Given the CloudFormation issue has been open for a while some extra voices may encourage a faster fix. |
@matthewtapper Thanks for that info. I am still curious about the steps you took. I was unable to reproduce this bug using the stack in our integ test, so curious what I'm missing. |
@SoManyHs we enabled the new ECS ARN format in order to add some cost allocation tags to ecs. This was done as follows:
With the above setting enabled valid CloudFormation is generated by cdk however the below portion of the stack fails as the
|
+1. I've also seen this consistently since enabling the new ARN format. I'm pretty sure that integ test will start failing as soon as the new format is enabled on the CDK integ account. |
Due to a bug in Cloudformation, Fn::GetAtt for service name on an ECS service was returning the cluster name instead of the service name. This was causing the ResourceId on AWS::ApplicationAutoScaling::ScalableTarget to be set incorrectly. Fixes aws#1849.
Due to a bug in Cloudformation, Fn::GetAtt for service name on an ECS service was returning the cluster name instead of the service name. This was causing the ResourceId on AWS::ApplicationAutoScaling::ScalableTarget to be set incorrectly. Fixes aws#1849.
Due to a bug in Cloudformation, Fn::GetAtt for service name on an ECS service was returning the cluster name instead of the service name. This was causing the ResourceId on AWS::ApplicationAutoScaling::ScalableTarget to be set incorrectly. This change forces the customer to specify whether they have opted into the long ARN format for services (which can be achieved through the following command: `aws ecs put-account-setting-default --name serviceLongArnFormat --value enabled`). The CDK cannot currently detect if the customer has the these settings enabled so there could be a potential conflict on deployment. Fixes aws#1849.
Due to a bug in Cloudformation, Fn::GetAtt for service name on an ECS service was returning the cluster name instead of the service name. This was causing the ResourceId on AWS::ApplicationAutoScaling::ScalableTarget to be set incorrectly. This change forces the customer to specify whether they have opted into the long ARN format for services (which can be achieved through the following command: `aws ecs put-account-setting-default --name serviceLongArnFormat --value enabled`). The CDK cannot currently detect if the customer has the these settings enabled so there could be a potential conflict on deployment. Fixes #1849.
Auto scaling of a Fargate service fails, if the new ECS ARN format has already been activated.
The following snippet creates an auto scaling Fargate service:
When the account (or user) already opted in to the new ECS ARN format, the Fargate service can be created, but autoscaling fails, as it generates the wrong service name:
The text was updated successfully, but these errors were encountered: