Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(device-farm): Support for device farm constructs #17893

Closed
2 tasks
SamStephens opened this issue Dec 7, 2021 · 4 comments · Fixed by #23928
Closed
2 tasks

(device-farm): Support for device farm constructs #17893

SamStephens opened this issue Dec 7, 2021 · 4 comments · Fixed by #23928
Labels
bug This issue is a bug. feature-request A feature should be added or improved. p1 package/cfn Related to the CFN layer (L1)

Comments

@SamStephens
Copy link
Contributor

Description

The AWS::DeviceFarm Cloudformation resources appear not to be exposed in the CDK at all.

This is a request for L1 constructs for those resources.

Use Case

To manage Device Farm resources via the CDK.

Proposed Solution

L1 Device Farm constructs.

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@SamStephens SamStephens added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 7, 2021
@indrora indrora added bug This issue is a bug. p1 package/cfn Related to the CFN layer (L1) and removed needs-triage This issue or PR still needs to be triaged. labels May 11, 2022
@workeitel
Copy link
Contributor

It looks like the problem is that the AWS CloudFormation resource specification is regional https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/cfn-resource-specification.html but CDK only imports from us-east-1: https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/cfnspec/build-tools/update.sh#L60

But AWS DeviceFarm service is only available in us-west-2 and therefore only part of the us-west-2 resource specification file.

@workeitel
Copy link
Contributor

By comparing the different regional files it turns out only Device Farm resources are affected:

"AWS::DeviceFarm::DevicePool"
"AWS::DeviceFarm::InstanceProfile"
"AWS::DeviceFarm::NetworkProfile"
"AWS::DeviceFarm::Project"
"AWS::DeviceFarm::TestGridProject"
"AWS::DeviceFarm::VPCEConfiguration"

All other resources in any other region are also part of the us-east-1 resource specification.

@SamStephens
Copy link
Contributor Author

Oh that's interesting. I guess this reflects an implicit assumption that products launch in us-east-1, and as such it's a framework-wide issue with the CDK. I've lodged #22565 to address this.

@mergify mergify bot closed this as completed in #23928 Jan 31, 2023
mergify bot pushed a commit that referenced this issue Jan 31, 2023
Some AWS services are only in us-west-2 region, while CDK uses the AWS CloudFormation resource specification from us-east-1 for generating L1.

This change adds suppport for resource specifications from additional regions, with an explicit allow list for services supported for this region.

Fixes #17893
Fixes #22565

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. feature-request A feature should be added or improved. p1 package/cfn Related to the CFN layer (L1)
Projects
None yet
3 participants