Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(apprunner): startCommand and environment are ignored in imageConfiguration #16812

Closed
pahud opened this issue Oct 6, 2021 · 4 comments · Fixed by #16939
Closed

(apprunner): startCommand and environment are ignored in imageConfiguration #16812

pahud opened this issue Oct 6, 2021 · 4 comments · Fixed by #16939
Labels
@aws-cdk/aws-ecr Related to Amazon Elastic Container Registry bug This issue is a bug. p1

Comments

@pahud
Copy link
Contributor

pahud commented Oct 6, 2021

What is the problem?

The startCommand and environment are ignored in the imageConfiguration.

Reproduction Steps

new appruner.Service(this, 'Service', {
    source: appruner.Source.fromEcrPublic({
      imageIdentifier: 'public.ecr.aws/pahudnet/flask-docker-sample:latest',
      imageConfiguration: {
        port: 80,
        startCommand: 'democommand',
        environment: {
          PLATFORM: 'AWS App Runner',
        },
      },
    }),
  });

What did you expect to happen?

the two properties should be properly configured..

What actually happened?

not configured in the synthesized cfn template

CDK CLI Version

1.126.0

Framework Version

No response

Node.js Version

v14.17.6

OS

mac os x

Language

Typescript

Language Version

No response

Other information

No response
@pahud pahud added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 6, 2021
@github-actions github-actions bot added the @aws-cdk/aws-ecr Related to Amazon Elastic Container Registry label Oct 6, 2021
@pahud
Copy link
Contributor Author

pahud commented Oct 6, 2021

I am working on the PR to fix this.

@peterwoodworth peterwoodworth added feature-request A feature should be added or improved. feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. and removed bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 12, 2021
@peterwoodworth
Copy link
Contributor

Hey @pahud, have you been able to work on this?

@pahud
Copy link
Contributor Author

pahud commented Oct 12, 2021

Hey @pahud, have you been able to work on this?

Yes. I'll create the PR today and link back to this issue.

@pahud pahud mentioned this issue Oct 13, 2021
Merged
2 tasks
@peterwoodworth peterwoodworth added bug This issue is a bug. and removed feature-request A feature should be added or improved. feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. labels Oct 13, 2021
@madeline-k madeline-k removed their assignment Nov 24, 2021
@mergify mergify bot closed this as completed in #16939 Nov 30, 2021
mergify bot pushed a commit that referenced this issue Nov 30, 2021
@pahud
fix(apprunner): startCommand and environment are ignored in imageConf…
d911c58 
…iguration (#16939)

This PR addresses the following issues

1. custom environment variables and start commands should be allowed for `imageConfiguration`
2. buildCommand, environment and startCommand should be allowed for `codeConfigurationValues`


Fixes: #16812 

- [x] add tests
- [x] implementation

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

pedrosola pushed a commit to pedrosola/aws-cdk that referenced this issue Dec 1, 2021
@pahud
fix(apprunner): startCommand and environment are ignored in imageConf…
e177859 
…iguration (aws#16939)

This PR addresses the following issues

1. custom environment variables and start commands should be allowed for `imageConfiguration`
2. buildCommand, environment and startCommand should be allowed for `codeConfigurationValues`


Fixes: aws#16812 

- [x] add tests
- [x] implementation

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Feb 21, 2022
@pahud @TikiTDO
fix(apprunner): startCommand and environment are ignored in imageConf…
5d5e7b4 
…iguration (aws#16939)

This PR addresses the following issues

1. custom environment variables and start commands should be allowed for `imageConfiguration`
2. buildCommand, environment and startCommand should be allowed for `codeConfigurationValues`


Fixes: aws#16812 

- [x] add tests
- [x] implementation

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ecr Related to Amazon Elastic Container Registry bug This issue is a bug. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(apprunner): startCommand and environment are ignored in imageConfiguration
3 participants
@pahud @peterwoodworth @madeline-k