Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): unknown command pytest in build container fails integration tests #16134

Merged
merged 1 commit into from
Aug 19, 2021
Merged

fix(cli): unknown command pytest in build container fails integration tests #16134

merged 1 commit into from
Aug 19, 2021

Conversation

BenChaimberg
Copy link
Contributor

Erroneously added in #15939

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@BenChaimberg BenChaimberg added the pr-linter/exempt-test The PR linter will not require test changes label Aug 19, 2021
@BenChaimberg BenChaimberg requested review from rix0rrr and a team August 19, 2021 15:56
@gitpod-io
Copy link

gitpod-io bot commented Aug 19, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 19, 2021
@BenChaimberg
Copy link
Contributor Author

Already reverted: 6d2a01d

@BenChaimberg
Copy link
Contributor Author

jk, that wasn't a commit on master

@BenChaimberg BenChaimberg reopened this Aug 19, 2021
@BenChaimberg
Copy link
Contributor Author

I can make the PR title prefix revert but I figured since we can leave the actual substance of the original commit in place and just fix the issue, maybe fix is better

@mergify mergify bot merged commit 0f7c0b4 into master Aug 19, 2021
@mergify mergify bot deleted the chaimber/fix_init_py_integ_pytest branch August 19, 2021 16:36
@mergify
Copy link
Contributor

mergify bot commented Aug 19, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: be7f497
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

smguggen pushed a commit to smguggen/aws-cdk that referenced this pull request Aug 24, 2021
@BenChaimberg @smguggen
fix(cli): unknown command pytest in build container fails integration…
cfb1c56 
… tests (aws#16134)

Erroneously added in aws#15939

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@BenChaimberg @hollanddd
fix(cli): unknown command pytest in build container fails integration…
b6e30af 
… tests (aws#16134)

Erroneously added in aws#15939

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Sep 6, 2021
@BenChaimberg @TikiTDO
fix(cli): unknown command pytest in build container fails integration…
07e55bc 
… tests (aws#16134)

Erroneously added in aws#15939

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this pull request Sep 7, 2021
@BenChaimberg @david-doyle-as24
fix(cli): unknown command pytest in build container fails integration…
5df6fa4 
… tests (aws#16134)

Erroneously added in aws#15939

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenChaimberg @aws-cdk-automation @rix0rrr