Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(efs): No way to specify FileSystemPolicy for FileSystem #15805

Closed
rectalogic opened this issue Jul 28, 2021 · 3 comments · Fixed by #24453
Closed

(efs): No way to specify FileSystemPolicy for FileSystem #15805

rectalogic opened this issue Jul 28, 2021 · 3 comments · Fixed by #24453
Labels
@aws-cdk/aws-efs Related to Amazon Elastic File System effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@rectalogic
Copy link
Contributor

We need to set a FileSystemPolicy on our EFS FileSystem
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-efs-filesystem.html#cfn-efs-filesystem-filesystempolicy

Can this only be set via property overrides?

Environment

  • CDK CLI Version : 2.0.0rc15
  • Framework Version: aws_cdk_lib-2.0.0rc15
  • Node.js Version: v14.17.1
  • OS : all
  • Language (Version): Python 3.8 (also all)

This is 🐛 Bug Report
@rectalogic rectalogic added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 28, 2021
@github-actions github-actions bot added the @aws-cdk/aws-efs Related to Amazon Elastic File System label Jul 28, 2021
@nija-at
Copy link
Contributor

nija-at commented Aug 23, 2021

Yes, you can use property overrides to set this value.

Marking it as a feature request.

@nija-at nija-at added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 and removed bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Aug 23, 2021
@nija-at nija-at removed their assignment Nov 25, 2021
@MrSyn88
Copy link
Contributor

MrSyn88 commented Nov 23, 2022

Taking a look a this

@WinterYukky WinterYukky mentioned this issue Mar 4, 2023
Merged
@mergify mergify bot closed this as completed in #24453 Mar 28, 2023
mergify bot pushed a commit that referenced this issue Mar 28, 2023
@WinterYukky
feat(efs): implement IResourceWithPolicy (#24453)
5771d79 
Implement `IResourceWithPolicy` in `FileSystem`.
Currently, `FileSystem` implements `FileSystemPolicy`. However, it does not implement `iam.IResourceWithPolicy`, which means that `iam.Grant.addToPrincipalOrResource` and `iam.Grant.addToPrincipalAndResource` cannot be used and is not compatible with other resources with resource policies. This PR makes it easier to extend `grantXxx`.

Closes #15805. (Already implemented `FileSystemPolicy`)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-efs Related to Amazon Elastic File System effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(efs): implement IResourceWithPolicy WinterYukky/aws-cdk
3 participants
@rectalogic @nija-at @MrSyn88