Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(apigatewayv2): get custom domain url for a given stage #15801

Closed
nija-at opened this issue Jul 28, 2021 · 2 comments · Fixed by #15973
Closed

(apigatewayv2): get custom domain url for a given stage #15801

nija-at opened this issue Jul 28, 2021 · 2 comments · Fixed by #15973
Labels
@aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@nija-at
Copy link
Contributor

nija-at commented Jul 28, 2021

Forked off #15689

The constructor for a Stage already accepts API mapping options, including custom domain name and mapping key.

Provide a way to get the URL for this stage that uses this API mapping instead of the execute-api endpoint.

This is a 🚀 Feature Request
@nija-at nija-at added good first issue Related to contributions. See CONTRIBUTING.md p2 feature-request A feature should be added or improved. effort/small Small work item – less than a day of effort @aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 labels Jul 28, 2021
@nija-at
Copy link
Contributor Author

nija-at commented Jul 28, 2021

The implementation will be a slightly different implementation of

aws-cdk/packages/@aws-cdk/aws-apigatewayv2/lib/http/stage.ts

Line 174 in dbe4641

public get url(): string {

@nija-at nija-at mentioned this issue Jul 28, 2021
Closed
@nija-at nija-at removed their assignment Jul 28, 2021
@samtwil samtwil mentioned this issue Aug 10, 2021
Merged
@mergify mergify bot closed this as completed in #15973 Aug 12, 2021
mergify bot pushed a commit that referenced this issue Aug 12, 2021
@samtwil
feat(apigatewayv2): http api - domain url for a stage (#15973)
bb5d587 
Closes #15801 

By adding and `apiMapping` field to base.ts, we can reference the custom domain information from the `HttpStage` construct

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
@samtwil @hollanddd
feat(apigatewayv2): http api - domain url for a stage (aws#15973)
8a8827a 
Closes aws#15801 

By adding and `apiMapping` field to base.ts, we can reference the custom domain information from the `HttpStage` construct

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this issue Sep 7, 2021
@samtwil @david-doyle-as24
feat(apigatewayv2): http api - domain url for a stage (aws#15973)
84836f9 
Closes aws#15801 

By adding and `apiMapping` field to base.ts, we can reference the custom domain information from the `HttpStage` construct

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(apigatewayv2): http api - domain url for a stage samtwil/aws-cdk
1 participant
@nija-at