Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-cdk): Broken link to integration test in CONTRIBUTING.md #15728

Closed
douglasnaphas opened this issue Jul 23, 2021 · 1 comment · Fixed by #15729
Closed

(aws-cdk): Broken link to integration test in CONTRIBUTING.md #15728

douglasnaphas opened this issue Jul 23, 2021 · 1 comment · Fixed by #15729
Labels
documentation This is a problem with documentation. feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@douglasnaphas
Copy link
Contributor

Doc: https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md#integration-tests
Permanent, line-specific link: https://github.com/aws/aws-cdk/blame/91cf79bc55ffd72b1c79e2218eb76921fbac32b4/CONTRIBUTING.md#L254

The Contributing guide has two links to example integration tests. The second link, to a file originally called packages/@aws-cdk/aws-apigateway/test/authorizers/integ.token-authorizer.ts, was renamed in #11384 to packages/@aws-cdk/aws-apigateway/test/authorizers/integ.token-authorizer.lit.ts.

Change the link in the Contributing guide to the correct name.

I will raise a PR momentarily to fix this.

This is a 📕 documentation issue
@douglasnaphas douglasnaphas added documentation This is a problem with documentation. feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 23, 2021
douglasnaphas added a commit to douglasnaphas/aws-cdk that referenced this issue Jul 23, 2021
@douglasnaphas
Fix link to example integration test
7ec2ae6 
Closes awsgh-15728.
@douglasnaphas douglasnaphas mentioned this issue Jul 23, 2021
Merged
@mergify mergify bot closed this as completed in #15729 Jul 23, 2021
mergify bot pushed a commit that referenced this issue Jul 23, 2021
@douglasnaphas
docs: fix link to example integration test in Contributing.md (#15729)
cb6e7c9 
Closes gh-15728.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Aug 3, 2021
@douglasnaphas @TikiTDO
docs: fix link to example integration test in Contributing.md (aws#15729
9496622 
)

Closes awsgh-15728.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
@douglasnaphas @hollanddd
docs: fix link to example integration test in Contributing.md (aws#15729
c3d175b 
)

Closes awsgh-15728.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation This is a problem with documentation. feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: fix link to example integration test in Contributing.md douglasnaphas/aws-cdk
1 participant
@douglasnaphas