Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ec2): Add rds-data VPC interface endpoints #15239

Closed
2 tasks
neilferreira opened this issue Jun 22, 2021 · 3 comments · Fixed by #15240
Closed
2 tasks

(ec2): Add rds-data VPC interface endpoints #15239

neilferreira opened this issue Jun 22, 2021 · 3 comments · Fixed by #15240
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1

Comments

@neilferreira
Copy link
Contributor

Add rds-data VPC interface endpoints

Use Case

VPC interface endpoints are supported for rds-data but don't exist in CDK:

https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/vpc-interface-endpoints.html

Proposed Solution

Add support for rds-data VPC interface endpoints

Other

Temporary workaround:

vpc.addInterfaceEndpoint("rds-data", {
      service: {
        name: `com.amazonaws.${process.env.CDK_DEFAULT_REGION}.rds-data`,
        port: 443,
      },

I "presume" the implementation would be:

public static readonly RDS = new InterfaceVpcEndpointAwsService('rds');

public static readonly RDS_DATA = new InterfaceVpcEndpointAwsService('rds-data');
  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@neilferreira neilferreira added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 22, 2021
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Jun 22, 2021
@neilferreira
Copy link
Contributor Author

@owenashurst
Copy link

owenashurst commented Jun 26, 2021

Just about to create an issue myself about this. Just popped a message on your PR. Seems like the title of the PR doesn't follow semantics. Also, thanks for the temporary workaround!

@njlynch njlynch added effort/small Small work item – less than a day of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels Jun 28, 2021
@njlynch njlynch removed their assignment Jun 28, 2021
@mergify mergify bot closed this as completed in #15240 Jul 5, 2021
mergify bot pushed a commit that referenced this issue Jul 5, 2021
Fixes #15239 (ec2): Add rds-data VPC interface endpoints 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Jul 5, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

upparekh pushed a commit to upparekh/aws-cdk that referenced this issue Jul 8, 2021
Fixes aws#15239 (ec2): Add rds-data VPC interface endpoints 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
Fixes aws#15239 (ec2): Add rds-data VPC interface endpoints 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants