v1.109.0 CLI cuts off step progress and outputs misleading "Failed resources:" message

[severn-everett]

When deploying an AWS stack using v1.109.0 the CLI...

• Outputs "Failed resources:" message even if all resources were deployed successfully.
• Does not print finished progress of every step.

Reproduction Steps

Upgrade from 1.108.1 to 1.109.0.

What did you expect to happen?

AWS stacks should deploy as they did before.

CDK_NEW_BOOTSTRAP set, using new-style bootstrapping
 ⏳  Bootstrapping environment aws://##########/eu-west-1...
Trusted accounts for deployment: (none)
Trusted accounts for lookup: (none)
Using default execution policy of 'arn:aws:iam::aws:policy/AdministratorAccess'. Pass '--cloudformation-execution-policies' to customize.
AN_AWS_STACK: creating CloudFormation changeset...
 0/4 | 15:13:48 | UPDATE_IN_PROGRESS   | AWS::CloudFormation::Stack | AN_AWS_STACK User Initiated
 0/4 | 15:13:54 | UPDATE_IN_PROGRESS   | AWS::IAM::Role        | FilePublishingRole
 0/4 | 15:13:54 | UPDATE_IN_PROGRESS   | AWS::IAM::Role        | ImagePublishingRole
 0/4 | 15:13:55 | UPDATE_IN_PROGRESS   | AWS::IAM::Role        | DeploymentActionRole
 3/4 | 15:14:10 | UPDATE_COMPLETE      | AWS::IAM::Role        | ImagePublishingRole
 3/4 | 15:14:10 | UPDATE_COMPLETE      | AWS::IAM::Role        | FilePublishingRole
 3/4 | 15:14:10 | UPDATE_COMPLETE      | AWS::IAM::Role        | DeploymentActionRole
 4/4 | 15:14:15 | UPDATE_COMPLETE_CLEA | AWS::CloudFormation::Stack | AN_AWS_STACK
 4/4 | 15:14:15 | UPDATE_COMPLETE      | AWS::CloudFormation::Stack | AN_AWS_STACK
 ✅  Environment aws://##########/eu-west-1 bootstrapped.

What actually happened?

The stack deployment fails to clean up, although the stack itself does get deployed.

CDK_NEW_BOOTSTRAP set, using new-style bootstrapping
 ⏳  Bootstrapping environment aws://##########/eu-west-1...
Trusted accounts for deployment: (none)
Trusted accounts for lookup: (none)
Using default execution policy of 'arn:aws:iam::aws:policy/AdministratorAccess'. Pass '--cloudformation-execution-policies' to customize.
AN_AWS_STACK: creating CloudFormation changeset...
  0/4 |15:20:04 | UPDATE_IN_PROGRESS   | AWS::CloudFormation::Stack | AN_AWS_STACK User Initiated
  0/4 |15:20:11 | UPDATE_IN_PROGRESS   | AWS::IAM::Role        | DeploymentActionRole
  0/4 |15:20:11 | UPDATE_IN_PROGRESS   | AWS::IAM::Role        | FilePublishingRole
  0/4 |15:20:11 | UPDATE_IN_PROGRESS   | AWS::IAM::Role        | ImagePublishingRole
  3/4 |15:20:28 | UPDATE_COMPLETE      | AWS::IAM::Role        | FilePublishingRole
  3/4 |15:20:28 | UPDATE_COMPLETE      | AWS::IAM::Role        | ImagePublishingRole
  3/4 |15:20:28 | UPDATE_COMPLETE      | AWS::IAM::Role        | DeploymentActionRole

Failed resources:
 ✅  Environment aws://##########/eu-west-1 bootstrapped.

Notice that step 4/4 did not print.

Environment

• **CDK CLI Version :1.109.0
• **Framework Version:1.109.0
• Node.js Version: 14.17.0
• **OS :Windows 10
• Language (Version): 4.3.2

Other

---

This is 🐛 Bug Report

[ryparker]

Hello @severn-everett 👋

After investigating this I've found that the CLI output can be a little misleading. The CLI will always output Failed resources: even when there are no failed deployments (implementation). As long as all resources listed have the green checkmark emoji (✅) this means that all resources succeeded.

You should be able to see that the stack was successfully deployed via the AWS console.

[severn-everett]

What about the cleanup step (4/4)? That output has disappeared in the deployments using 1.109.0 as well.

[ryparker]

I missed that bug, sorry about that. I opened a PR to fix the misleading Failed resources: message but will need to dedicate more time into investigating the cutoff of step progress output.

I am marking this issue as p1 due to the number of users that will be impacted. It has been prioritized as important and should see attention soon. We use +1s to help us prioritize our work.

[ryparker]

Fix for both the Failed resources: output and progress cutoff has been implemented in #15207

Waiting on review and merge 🙂

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.