(aws-resourcegroups) ResourceGroup doesn't properly inherit Tags, causes deploy failure

[EhrhardtDa]

The Question

I get the folllowing error, when I try to deploy a stack including global tags and a ResourceGroup.

Environment

• CDK CLI Version: 1.89.0
• Module Version: 1.89.0
• Node.js Version: v14.15.4
• OS: Windows 10
• Language: TypeScript

Other information

cdk.Tags.of(this).add('myTagA', tagValueA);
cdk.Tags.of(this).add('myTagB', tagValueB);

...

let resourceGroupName = `BaKo-TIS-${props.environmentName}`;
const ressourceGroup = new resourcegroups.CfnGroup(this, 'ResourceGroup',{
  name: resourceGroupName,
});
const application = new applicationinsights.CfnApplication(this, 'Application', {
  resourceGroupName,
});

[ 1/4 | 15:42:57 | CREATE_FAILED        | AWS::ResourceGroups::Group                | ResourceGroup Model validation failed (#/Tags: expected type: JSONArray, found: JSONObject)
        new TisAgentAppStack (D:\Git\tis-agent\lib\tis-agent-stack.ts:189:28)
        \_ Object.<anonymous> (D:\Git\tis-agent\bin\tis-agent.ts:21:1)
        \_ Module._compile (internal/modules/cjs/loader.js:1063:30)
        \_ Module.m._compile (D:\Git\tis-agent\node_modules\ts-node\src\index.ts:1056:23)
        \_ Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
        \_ Object.require.extensions.<computed> [as .ts] (D:\Git\tis-agent\node_modules\ts-node\src\index.ts:1059:12)
        \_ Module.load (internal/modules/cjs/loader.js:928:32)
        \_ Function.Module._load (internal/modules/cjs/loader.js:769:14)
        \_ Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)
        \_ main (D:\Git\tis-agent\node_modules\ts-node\src\bin.ts:198:14)
        \_ Object.<anonymous> (D:\Git\tis-agent\node_modules\ts-node\src\bin.ts:288:3)
        \_ Module._compile (internal/modules/cjs/loader.js:1063:30)
        \_ Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
        \_ Module.load (internal/modules/cjs/loader.js:928:32)
        \_ Function.Module._load (internal/modules/cjs/loader.js:769:14)
        \_ Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)
        \_ internal/main/run_main_module.js:17:47
]

[peterwoodworth]

I can confirm that this is a bug and still occurring in 1.116.0.

relevant synth output for ResourceGroup:

"Tags": {
  "myTagA": "myValueA",
  "myTagB": "myValueB"
}

I tested to see if the same configuration happens with other Cfn resources (such as Bucket), the issue seems to be isolated to CfnGroup but there could potentially be other cases of this happening.

[alexmcmanus]

The underlying problem is that it configures a TagManager with the wrong type. It's probably a simple fix, and I'd be happy to submit a PR - except that it's in generated code, and I can't see where I'd need to make the change. The following workaround is possible in the meantime:

    const resourceGroup = new CfnGroup(this, 'ResourceGroup', {
      // ...etc.
    })
    // eslint-disable-next-line @typescript-eslint/no-explicit-any
    ;(resourceGroup as any).tags = new TagManager(TagType.STANDARD, 'AWS::ResourceGroups::Group', undefined, {
      tagPropertyName: 'tags'
    })

[madeline-k]

For some reason there is a patch to the cfn spec for ResoureGroups which is causing the tag type to be MAP instead of STANDARD: https://github.com/aws/aws-cdk/blob/master/packages/@aws-cdk/cfnspec/spec-source/530_ResourceGroups_Tags_patch.json

If we remove this patch, then the tag type will be STANDARD.

The PR where it was added: #6995 (comment)

I will consult with the team to see if it can be removed.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.