Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(apigatewayv2): Expose DomainName mTLS config #12559

Closed
2 tasks
mtaron opened this issue Jan 18, 2021 · 2 comments · Fixed by #17284
Closed
2 tasks

(apigatewayv2): Expose DomainName mTLS config #12559

mtaron opened this issue Jan 18, 2021 · 2 comments · Fixed by #17284
Labels
@aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 effort/small Small work item – less than a day of effort feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs feature-request A feature should be added or improved. p2

Comments

@mtaron
Copy link

mtaron commented Jan 18, 2021 •
edited
Loading

API Gateway V2 supports mTLS [docs]. It is exposed on the API Gateway V1 L2 construct, but not on the V2 L2 construct.

Use Case

Blocks usage of the L2 construct for API Gateway V2.

Proposed Solution

Extend this PR to API Gateway V2.

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@mtaron mtaron added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 18, 2021
@github-actions github-actions bot added the @aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 label Jan 18, 2021
@nija-at nija-at added effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Jan 18, 2021
@ericzbeard ericzbeard added the feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs label Apr 2, 2021
@ashishpandey001
Copy link

Are there any plans to implement this change?

@serahisaactho serahisaactho mentioned this issue Nov 2, 2021
Merged
@mergify mergify bot closed this as completed in #17284 Nov 9, 2021
mergify bot pushed a commit that referenced this issue Nov 9, 2021
@serahisaactho
feat(apigatewayv2): http api - mTLS support (#17284)
54be156 
Resolves #12559 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Nov 9, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Feb 21, 2022
@serahisaactho @TikiTDO
feat(apigatewayv2): http api - mTLS support (aws#17284)
fb63c70 
Resolves aws#12559 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 effort/small Small work item – less than a day of effort feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(apigatewayv2): http api - mTLS support serahisaactho/aws-cdk
4 participants
@ericzbeard @mtaron @ashishpandey001 @nija-at