Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Standard 5.0 in CodeBuild #12433

Closed
1 of 2 tasks
xian13 opened this issue Jan 9, 2021 · 1 comment · Fixed by #12434
Closed
1 of 2 tasks

Support Standard 5.0 in CodeBuild #12433

xian13 opened this issue Jan 9, 2021 · 1 comment · Fixed by #12434
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@xian13
Copy link
Contributor

xian13 commented Jan 9, 2021

Use Case

CodeBuild released new images in v21.01.08
Details: https://github.com/aws/aws-codebuild-docker-images/releases/tag/21.01.08

Proposed Solution

The standard 5.0 need to be added at codebuild project

aws-cdk/packages/@aws-cdk/aws-codebuild/lib/project.ts

Lines 1434 to 1439 in da1ed08

public static readonly STANDARD_1_0 = LinuxBuildImage.codeBuildImage('aws/codebuild/standard:1.0');
public static readonly STANDARD_2_0 = LinuxBuildImage.codeBuildImage('aws/codebuild/standard:2.0');
public static readonly STANDARD_3_0 = LinuxBuildImage.codeBuildImage('aws/codebuild/standard:3.0');
/** The `aws/codebuild/standard:4.0` build image. */
public static readonly STANDARD_4_0 = LinuxBuildImage.codeBuildImage('aws/codebuild/standard:4.0');

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@xian13 xian13 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 9, 2021
xian13 added a commit to xian13/aws-cdk that referenced this issue Jan 9, 2021
@xian13
feat(codebuild): support Standard 5.0
564919a 
Closes: aws#12433
@xian13 xian13 mentioned this issue Jan 9, 2021
Merged
@mergify mergify bot closed this as completed in #12434 Jan 11, 2021
mergify bot pushed a commit that referenced this issue Jan 11, 2021
@xian13
feat(codebuild): support Standard 5.0 (#12434)
422dc8e 
Closes: #12433


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(codebuild): support Standard 5.0 xian13/aws-cdk
1 participant
@xian13