Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-apigatewayv2-integrations): integration sub type - step functions #11947

Closed
davingreen opened this issue Dec 8, 2020 · 3 comments
Closed

(aws-apigatewayv2-integrations): integration sub type - step functions #11947

davingreen opened this issue Dec 8, 2020 · 3 comments
Labels
@aws-cdk/aws-apigatewayv2-integrations Related to AWS APIGatewayv2 Integrations closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@davingreen
Copy link

The Question

I don't see a way of adding Step Functions as an integration on a route. Is this not available yet? Is there a workaround?

Thanks!

Environment

  • CDK CLI Version: <1.77.0
  • Node.js Version: v12.18.3
@davingreen davingreen added guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Dec 8, 2020
@github-actions github-actions bot added the @aws-cdk/aws-apigatewayv2-integrations Related to AWS APIGatewayv2 Integrations label Dec 8, 2020
@drobtravels
Copy link

There does not appear to be support for any of the HTTP API service integrations at this time. I don't see it noted on the roadmap either.

Would be a great addition.

@nija-at nija-at changed the title (aws-apigatewayv2-integrations): step functions? (aws-apigatewayv2-integrations): integration sub type - step functions Jan 14, 2021
@nija-at nija-at mentioned this issue Jan 14, 2021
Closed
@nija-at nija-at added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. and removed guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Jan 14, 2021
shankben added a commit to shankben/aws-cdk that referenced this issue Feb 12, 2021
@shankben
feat(aws-apigatewayv2-integrations): Introduce L2 construct for Event…
408ad94 
…Bridge-PutEvents AWS service integration

This is in reference to GitHub Issue aws#11947

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
shankben added a commit to shankben/aws-cdk that referenced this issue Feb 12, 2021
@shankben
feat(aws-apigatewayv2-integrations): Introduce L2 construct for Event…
997c17b 
…Bridge-PutEvents AWS service integration

This is in reference to GitHub Issue aws#11947

BREAKING CHANGE: In order to propagate necessary configuration parameters to the AWS service integration type, the following breaking changes were introduced:
* **aws-apigatewayv2:** Added AWS_PROXY enum property to HttpIntegrationType
* **aws-apigatewayv2:** Added nullable integrationSubtype and nullable requestParameters types to HttpIntegrationProps
* **aws-apigatewayv2:** Changed integrationUri in HttpIntegrationProps to a nullable type as AWS service integrations do not require this field per the CloudFormation spec
* **aws-apigatewayv2:** Bubbled up nullable credentialsArn in HttpIntegrationProps
* **aws-apigatewayv2:** Modified constructor of HttpIntegration to throw an Error if AWS_PROXY parameters are misconfigured
* **aws-apigatewayv2:** Sorted properties in call to new CfnIntegration in constructor of HttpIntegration
* **aws-apigatewayv2:** Introduced private method renderRequestParameters to convert L2 requestParameters to CloudFormation compantible property names
* **aws-apigatewayv2:** Modified uri in HttpRouteIntegrationConfig to a nullable type as AWS service integrations do not require this field per the CloudFormation spec
* **aws-apigatewayv2:** Added nullable credentialsArn, nullable integrationSubtype, and nullable requestParameters in HttpRouteIntegrationConfig
shankben added a commit to shankben/aws-cdk that referenced this issue Feb 12, 2021
@shankben
feat(aws-apigatewayv2-integrations): Introduce L2 construct for Event…
cc206d7 
…Bridge-PutEvents AWS service integration

This is in reference to GitHub Issue aws#11947

BREAKING CHANGE: In order to propagate necessary configuration parameters to the AWS service integration type, the following breaking changes were introduced:
* **aws-apigatewayv2:** Added AWS_PROXY enum property to HttpIntegrationType
* **aws-apigatewayv2:** Added nullable integrationSubtype and nullable requestParameters types to HttpIntegrationProps
* **aws-apigatewayv2:** Changed integrationUri in HttpIntegrationProps to a nullable type as AWS service integrations do not require this field per the CloudFormation spec
* **aws-apigatewayv2:** Bubbled up nullable credentialsArn in HttpIntegrationProps
* **aws-apigatewayv2:** Modified constructor of HttpIntegration to throw an Error if AWS_PROXY parameters are misconfigured
* **aws-apigatewayv2:** Sorted properties in call to new CfnIntegration in constructor of HttpIntegration
* **aws-apigatewayv2:** Introduced private method renderRequestParameters to convert L2 requestParameters to CloudFormation compantible property names
* **aws-apigatewayv2:** Modified uri in HttpRouteIntegrationConfig to a nullable type as AWS service integrations do not require this field per the CloudFormation spec
* **aws-apigatewayv2:** Added nullable credentialsArn, nullable integrationSubtype, and nullable requestParameters in HttpRouteIntegrationConfig
shankben added a commit to shankben/aws-cdk that referenced this issue Feb 12, 2021
@shankben
feat(aws-apigatewayv2-integrations): Introduce L2 construct for Event…
98591f7 
…Bridge-PutEvents AWS service integration

This is in reference to GitHub Issue aws#11947

BREAKING CHANGE: In order to propagate necessary configuration parameters to the AWS service integration type, the following breaking changes were introduced:
* **aws-apigatewayv2:** Added AWS_PROXY enum property to HttpIntegrationType
* **aws-apigatewayv2:** Added nullable integrationSubtype and nullable requestParameters types to HttpIntegrationProps
* **aws-apigatewayv2:** Changed integrationUri in HttpIntegrationProps to a nullable type as AWS service integrations do not require this field per the CloudFormation spec
* **aws-apigatewayv2:** Bubbled up nullable credentialsArn in HttpIntegrationProps
* **aws-apigatewayv2:** Modified constructor of HttpIntegration to throw an Error if AWS_PROXY parameters are misconfigured
* **aws-apigatewayv2:** Sorted properties in call to new CfnIntegration in constructor of HttpIntegration
* **aws-apigatewayv2:** Introduced private method renderRequestParameters to convert L2 requestParameters to CloudFormation compantible property names
* **aws-apigatewayv2:** Modified uri in HttpRouteIntegrationConfig to a nullable type as AWS service integrations do not require this field per the CloudFormation spec
* **aws-apigatewayv2:** Added nullable credentialsArn, nullable integrationSubtype, and nullable requestParameters in HttpRouteIntegrationConfig
@shankben shankben mentioned this issue Feb 12, 2021
Closed
shankben added a commit to shankben/aws-cdk that referenced this issue Feb 19, 2021
@shankben
Related to: aws#11947
0079639 
In order to propagate necessary configuration parameters to the AWS service integration type, the following changes were introduced:

- Added AWS_PROXY enum property to HttpIntegrationType
- Added nullable integrationSubtype and nullable requestParameters types to HttpIntegrationProps
- Added nullable credentialsArn, nullable integrationSubtype, and nullable requestParameters in HttpRouteIntegrationConfig
- Changed integrationUri in HttpIntegrationProps to a nullable type as AWS service integrations do not require this field per the CloudFormation spec
- Bubbled up nullable credentialsArn in HttpIntegrationProps
- Sorted properties in call to new CfnIntegration in constructor of HttpIntegration
- Introduced private method renderRequestParameters to convert L2 requestParameters to CloudFormation compantible property names
- Modified uri in HttpRouteIntegrationConfig to a nullable type as AWS service integrations do not require this field per the CloudFormation spec
- Modified constructor of HttpIntegration to throw an Error if AWS_PROXY parameters are misconfigured
@nija-at nija-at mentioned this issue Mar 5, 2021
Closed
2 tasks
@nija-at nija-at added the p2 label Mar 22, 2021
@zxkane zxkane mentioned this issue May 3, 2021
Closed
@nija-at nija-at mentioned this issue Jun 11, 2021
Closed
2 tasks
@alanraison alanraison mentioned this issue Aug 30, 2021
Closed
saqibdhuka pushed a commit to zxkane/aws-cdk that referenced this issue Oct 1, 2021
Added StepFunctionsStartExecutionIntegration and StepFunctionsStartSy…
711b6cb 
…ncExecutionIntegration.

Added unit and integration tests.
Squashing all commits with rebase of master.

closes aws#11947.
saqibdhuka pushed a commit to zxkane/aws-cdk that referenced this issue Oct 2, 2021
Added StepFunctionsStartExecutionIntegration and StepFunctionsStartSy…
16447ea 
…ncExecutionIntegration.

Added unit and integration tests.
Squashing all commits with rebase of master.

closes aws#11947.

Added StepFunctionsStartExecutionIntegration and StepFunctionsStartSyncExecutionIntegration.
Added unit and integration tests.
Squashing all commits with rebase of master.

closes aws#11947.
saqibdhuka pushed a commit to zxkane/aws-cdk that referenced this issue Oct 2, 2021
Added StepFunctionsStartExecutionIntegration and StepFunctionsStartSy…
6ffc044 
…ncExecutionIntegration.

Added unit and integration tests.
Squashing all commits with rebase of master.
Fixed issues mentioned in the Pull-request.
closes aws#11947.
saqibdhuka pushed a commit to zxkane/aws-cdk that referenced this issue Oct 2, 2021
Added StepFunctionsStartExecutionIntegration and StepFunctionsStartSy…
b73875a 
…ncExecutionIntegration.

Added unit and integration tests.
Squashing all commits with rebase of master.
Fixed issues mentioned in the Pull-request.
closes aws#11947.
saqibdhuka pushed a commit to zxkane/aws-cdk that referenced this issue Oct 2, 2021
Added StepFunctionsStartExecutionIntegration and StepFunctionsStartSy…
6551bec 
…ncExecutionIntegration.

Added unit and integration tests.
Squashing all commits with rebase of master.
Fixed issues mentioned in the Pull-request.

closes aws#11947.
saqibdhuka pushed a commit to zxkane/aws-cdk that referenced this issue Oct 2, 2021
Added StepFunctionsStartExecutionIntegration and StepFunctionsStartSy…
009114d 
…ncExecutionIntegration.

Added unit and integration tests.
Fixed issues mentioned in the Pull-request.

closes aws#11947.
saqibdhuka pushed a commit to zxkane/aws-cdk that referenced this issue Oct 7, 2021
Added StepFunctionsStartExecutionIntegration and StepFunctionsStartSy…
afc9ef9 
…ncExecutionIntegration.

Added unit and integration tests.
Fixed issues mentioned in the Pull-request.

closes aws#11947.
saqibdhuka pushed a commit to zxkane/aws-cdk that referenced this issue Oct 14, 2021
Added StepFunctionsStartExecutionIntegration and StepFunctionsStartSy…
0a6a1b1 
…ncExecutionIntegration.

Added unit and integration tests.
Fixed issues mentioned in the Pull-request.
Added example to README

closes aws#11947.
saqibdhuka pushed a commit to zxkane/aws-cdk that referenced this issue Oct 14, 2021
Added StepFunctionsStartExecutionIntegration and StepFunctionsStartSy…
2015d58 
…ncExecutionIntegration.

Added unit and integration tests.
Fixed issues mentioned in the Pull-request.
Added example to README

closes aws#11947.
saqibdhuka pushed a commit to zxkane/aws-cdk that referenced this issue Oct 14, 2021
Added StepFunctionsStartExecutionIntegration and StepFunctionsStartSy…
98e87a2 
…ncExecutionIntegration.

Added unit and integration tests.
Fixed issues mentioned in the Pull-request.
Added example to README

closes aws#11947.
saqibdhuka pushed a commit to zxkane/aws-cdk that referenced this issue Oct 14, 2021
Added StepFunctionsStartExecutionIntegration and StepFunctionsStartSy…
a50b049 
…ncExecutionIntegration.

Added unit and integration tests.
Fixed issues mentioned in the Pull-request.
Added example to README

closes aws#11947.
saqibdhuka pushed a commit to zxkane/aws-cdk that referenced this issue Nov 4, 2021
Added StepFunctionsStartExecutionIntegration and StepFunctionsStartSy…
9c04142 
…ncExecutionIntegration.

Added unit and integration tests.
Fixed issues mentioned in the Pull-request.
Added example to README

closes aws#11947.
saqibdhuka pushed a commit to zxkane/aws-cdk that referenced this issue Nov 4, 2021
Added StepFunctionsStartExecutionIntegration and StepFunctionsStartSy…
1e2999c 
…ncExecutionIntegration.

Added unit and integration tests.
Fixed issues mentioned in the Pull-request.
Added example to README
Fixed unit test

closes aws#11947.
@douglasnaphas
Copy link
Contributor

It looks like #1465 has workarounds using L1 Constructs.

@github-actions
Copy link

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Dec 30, 2022
@github-actions github-actions bot closed this as completed Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-apigatewayv2-integrations Related to AWS APIGatewayv2 Integrations closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(apigatewayv2): add aws service integration -- step functions zxkane/aws-cdk
4 participants
@drobtravels @douglasnaphas @davingreen @nija-at