Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-batch] expose log group on batch job definition #11218

Closed
2 tasks
mariusingjer opened this issue Oct 30, 2020 · 2 comments · Fixed by #11771
Closed
2 tasks

[aws-batch] expose log group on batch job definition #11218

mariusingjer opened this issue Oct 30, 2020 · 2 comments · Fixed by #11771
Assignees
Labels
@aws-cdk/aws-batch Related to AWS Batch effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p1

Comments

@mariusingjer
Copy link

Use Case

Proposed Solution

Expose logConfiguration from AWS::Batch::JobDefinition ContainerProperties, so you don't have to do this:

    const jobDefinition = new batch.JobDefinition(this, 'job-definition', {
        ...
    });

    const l1jobDefinition = jobDefinition.node.defaultChild as batch.CfnJobDefinition;
    l1jobDefinition.addOverride('Properties.ContainerProperties.LogConfiguration.LogDriver', 'awslogs');
    l1jobDefinition.addOverride('Properties.ContainerProperties.LogConfiguration.Options.awslogs-stream-prefix', 'my-own-log-group-name');
    l1jobDefinition.addOverride('Properties.ContainerProperties.LogConfiguration.Options.awslogs-region', '...');
    l1jobDefinition.addOverride('Properties.ContainerProperties.LogConfiguration.Options.awslogs-group.Ref', (logGroup.node.defaultChild as cdk.CfnElement).logicalId);
  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@mariusingjer mariusingjer added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 30, 2020
@github-actions github-actions bot added the @aws-cdk/aws-batch Related to AWS Batch label Oct 30, 2020
@iliapolo iliapolo added effort/small Small work item – less than a day of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels Nov 9, 2020
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Dec 7, 2020
@mergify mergify bot closed this as completed in #11771 Dec 9, 2020
mergify bot pushed a commit that referenced this issue Dec 9, 2020
@github-actions
Copy link

github-actions bot commented Dec 9, 2020

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

flochaz pushed a commit to flochaz/aws-cdk that referenced this issue Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-batch Related to AWS Batch effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants