Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(apigatewayv2): http api - endpoint url #11092

Merged
merged 10 commits into from
Oct 30, 2020
Merged

feat(apigatewayv2): http api - endpoint url #11092

merged 10 commits into from
Oct 30, 2020

Conversation

iRoachie
Copy link
Contributor

fixes #10651

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 25, 2020 •
edited
Loading

nija-at
nija-at previously requested changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. Couple of minor comments.

packages/@aws-cdk/aws-apigatewayv2/test/http/api.test.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigatewayv2/README.md Outdated Show resolved Hide resolved
@iRoachie
Update packages/@aws-cdk/aws-apigatewayv2/test/http/api.test.ts
a19d864 
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
@mergify mergify bot dismissed nija-at’s stale review October 28, 2020 16:44

Pull request has been modified.

@iRoachie
Updated apiEndpoint example
8e7ba5e 
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
@iRoachie
Copy link
Contributor Author

@nija-at Changes made

@iRoachie iRoachie requested a review from nija-at October 28, 2020 16:50
@nija-at nija-at changed the title feat(apigatewayv2): Export apiEndpoint feat(apigatewayv2): http api - endpoint url Oct 29, 2020
nija-at
nija-at previously approved these changes Oct 29, 2020
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Oct 29, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed nija-at’s stale review October 29, 2020 16:07

Pull request has been modified.

@iRoachie
Copy link
Contributor Author

iRoachie commented Oct 29, 2020 •
edited
Loading

@nija-at Not sure if you're sure of the cause, but the test for @aws-cdk/aws-lambda-nodejs frequently fails. Seen it couple times now, even though the code is unrelated. Always seems to resolve itself after merging master branch in again

@iRoachie iRoachie requested a review from nija-at October 29, 2020 16:09
@nija-at nija-at mentioned this pull request Oct 30, 2020
Closed
@nija-at
Copy link
Contributor

nija-at commented Oct 30, 2020

@iRoachie -

@nija-at Not sure if you're sure of the cause, but the test for @aws-cdk/aws-lambda-nodejs frequently fails. Seen it couple times now, even though the code is unrelated. Always seems to resolve itself after merging master branch in again

I've opened an issue to track this - #11222

nija-at
nija-at previously approved these changes Oct 30, 2020
View reviewed changes
@nija-at nija-at dismissed their stale review October 30, 2020 15:20

merge conflicts

nija-at
nija-at previously requested changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GH is showing some merge conflicts on api.test.ts. Could you resolve them?

The code looks good to me otherwise.

@mergify mergify bot dismissed nija-at’s stale review October 30, 2020 15:32

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: c9ca154
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@iRoachie
Copy link
Contributor Author

Updated @nija-at

@iRoachie iRoachie requested a review from nija-at October 30, 2020 16:05
@mergify
Copy link
Contributor

mergify bot commented Oct 30, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c200413 into aws:master Oct 30, 2020
@iRoachie iRoachie deleted the apigatewayv2-apiEndpoint branch October 30, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nija-at nija-at nija-at approved these changes

Assignees

@nija-at nija-at

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[aws-apigatewayv2] Add support for resource attribute - ApiEndpoint
3 participants
@iRoachie @nija-at @aws-cdk-automation