Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws-apigatewayv2] Add support for resource attribute - ApiEndpoint #10651

Closed
2 tasks
shivlaks opened this issue Oct 2, 2020 · 2 comments · Fixed by #11092
Closed
2 tasks

[aws-apigatewayv2] Add support for resource attribute - ApiEndpoint #10651

shivlaks opened this issue Oct 2, 2020 · 2 comments · Fixed by #11092
Assignees
@nija-at
Labels
@aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md in-progress This issue is being actively worked on. p2

Comments

@shivlaks
Copy link
Contributor

shivlaks commented Oct 2, 2020

The import of CloudFormation resource specification 18.4 in #10493, ApiGatewayv2 added
a new attribute called ApiEndpoint

This attribute is not currently exposed through our L2 construct.
A linter exclusion was added to avoid conflation of the feature into the same PR as the spec import.

This is a tracking issue to ensure we expose it (and get rid of the linter exclusion)

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@shivlaks shivlaks added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 2, 2020
@github-actions github-actions bot added the @aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 label Oct 2, 2020
@nija-at nija-at added effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p2 labels Oct 12, 2020
@iRoachie
Copy link
Contributor

@shivlaks I don't mind working on this 👋

@iRoachie iRoachie mentioned this issue Oct 25, 2020
Merged
@SomayaB SomayaB added in-progress This issue is being actively worked on. and removed needs-triage This issue or PR still needs to be triaged. labels Oct 26, 2020
@mergify mergify bot closed this as completed in #11092 Oct 30, 2020
mergify bot pushed a commit that referenced this issue Oct 30, 2020
@iRoachie
feat(apigatewayv2): http api - endpoint url (#11092)
c200413 
fixes #10651


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nija-at nija-at

Labels
@aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md in-progress This issue is being actively worked on. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(apigatewayv2): http api - endpoint url
4 participants
@iRoachie @nija-at @SomayaB @shivlaks