Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[elasticloadbalancingv2] load balancers by lookup #11088

Closed
1 of 2 tasks
misterjoshua opened this issue Oct 24, 2020 · 1 comment · Fixed by #11089
Closed
1 of 2 tasks

[elasticloadbalancingv2] load balancers by lookup #11088

misterjoshua opened this issue Oct 24, 2020 · 1 comment · Fixed by #11089
Assignees
@njlynch
Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p2

Comments

@misterjoshua
Copy link
Contributor

misterjoshua commented Oct 24, 2020 •
edited
Loading

I'd like my constructs to discover load balancers and listeners by tags, ports, and protocols.

Use Case

We share load balancers on shared ECS clusters between several CDK-based services for cost-reduction reasons. Because of this, we often need to import the load balancer and listener configuration. Right now we're using .from*Attributes() method, but this results in a lot of copy-pasting of attribute values. If we could look up a load balancer or listener by tags, then we could replace the copy-pasting with a tag-based discovery method.

Proposed Solution

We could implement a context provider for load balancers and allow the user to look up values the same way as Vpc.fromLookup().

Other

I'm working on a PR for this right now. I'll mention this issue when I've got the PR up.

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@misterjoshua misterjoshua added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 24, 2020
@github-actions github-actions bot added the @aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 label Oct 24, 2020
@misterjoshua misterjoshua mentioned this issue Oct 24, 2020
Merged
@njlynch njlynch added effort/large Large work item – several weeks of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Oct 26, 2020
@mergify mergify bot closed this as completed in #11089 Nov 9, 2020
mergify bot pushed a commit that referenced this issue Nov 9, 2020
@misterjoshua
feat(elasticloadbalancingv2): add load balancer lookups (#11089)
0153028 
Adds `fromLookup()` methods to both Application and Network load balancers as well as their listeners.

Closes #11088 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Nov 9, 2020

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njlynch njlynch

Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(elasticloadbalancingv2): add load balancer lookups misterjoshua/aws-cdk
2 participants
@misterjoshua @njlynch