Change timestamp to number

aws · Mar 28, 2024 · cbf852d · cbf852d
1 parent 89b108b
commit cbf852d
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/packages/@aws-cdk/aws-pipes-sources-alpha/lib/kinesis.ts b/packages/@aws-cdk/aws-pipes-sources-alpha/lib/kinesis.ts
@@ -87,11 +87,14 @@ export interface KinesisSourceParameters {
 
   /**
    * With StartingPosition set to AT_TIMESTAMP, the time from which to start reading, in Unix time seconds.
+   * 
+   * @example
+   * 1711576897
    *
    * @see https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-pipes-pipe-pipesourcekinesisstreamparameters.html#cfn-pipes-pipe-pipesourcekinesisstreamparameters-startingpositiontimestamp
    * @default - no starting position timestamp
    */
-  readonly startingPositionTimestamp?: string;
+  readonly startingPositionTimestamp?: number;
 }
 
 /**
@@ -168,7 +171,7 @@ export class KinesisSource implements ISource {
           onPartialBatchItemFailure: this.sourceParameters.onPartialBatchItemFailure,
           parallelizationFactor: this.sourceParameters.parallelizationFactor,
           startingPosition: this.sourceParameters.startingPosition,
-          startingPositionTimestamp: this.sourceParameters.startingPositionTimestamp,
+          startingPositionTimestamp: this.sourceParameters.startingPositionTimestamp?.toString(),
         },
       },
     };

diff --git a/packages/@aws-cdk/aws-pipes-sources-alpha/test/integ.kinesis.ts b/packages/@aws-cdk/aws-pipes-sources-alpha/test/integ.kinesis.ts
@@ -36,6 +36,7 @@ const sourceUnderTest = new KinesisSource(sourceKinesisStream, {
   onPartialBatchItemFailure: OnPartialBatchItemFailure.AUTOMATIC_BISECT,
   parallelizationFactor: 1,
   startingPosition: KinesisStartingPosition.LATEST,
+  startingPositionTimestamp: 1711576897,
 });
 
 new Pipe(stack, 'Pipe', {

diff --git a/packages/@aws-cdk/aws-pipes-sources-alpha/test/kinesis.test.ts b/packages/@aws-cdk/aws-pipes-sources-alpha/test/kinesis.test.ts
@@ -56,7 +56,7 @@ describe('kinesis source', () => {
       onPartialBatchItemFailure: OnPartialBatchItemFailure.AUTOMATIC_BISECT,
       parallelizationFactor: 10,
       startingPosition: KinesisStartingPosition.LATEST,
-      startingPositionTimestamp: 'MyTimestamp',
+      startingPositionTimestamp: 1711576897,
     });
 
     new Pipe(stack, 'MyPipe', {
@@ -87,7 +87,7 @@ describe('kinesis source', () => {
           OnPartialBatchItemFailure: 'AUTOMATIC_BISECT',
           ParallelizationFactor: 10,
           StartingPosition: 'LATEST',
-          StartingPositionTimestamp: 'MyTimestamp',
+          StartingPositionTimestamp: '1711576897',
         },
       },
     });
@@ -108,7 +108,7 @@ describe('kinesis source', () => {
       onPartialBatchItemFailure: OnPartialBatchItemFailure.AUTOMATIC_BISECT,
       parallelizationFactor: 10,
       startingPosition: KinesisStartingPosition.LATEST,
-      startingPositionTimestamp: 'MyTimestamp',
+      startingPositionTimestamp: 1711576897,
     });
 
     new Pipe(stack, 'MyPipe', {
@@ -144,7 +144,7 @@ describe('kinesis source', () => {
           OnPartialBatchItemFailure: 'AUTOMATIC_BISECT',
           ParallelizationFactor: 10,
           StartingPosition: 'LATEST',
-          StartingPositionTimestamp: 'MyTimestamp',
+          StartingPositionTimestamp: '1711576897',
         },
       },
     });