Skip to content

Commit

Permalink
Merge branch 'main' into merge-back/2.162.1
Browse files Browse the repository at this point in the history
  • Loading branch information
mergify[bot] authored Oct 15, 2024
2 parents adaaba5 + 78a7182 commit 9e573e0
Show file tree
Hide file tree
Showing 83 changed files with 86,806 additions and 102 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/request-cli-integ-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
git config --global user.email 'aws-cdk-automation@users.noreply.github.com'
git push --force --atomic https://github.com/${{ github.repository }}.git FETCH_HEAD:test-main-pipeline
- name: Explain next steps
uses: thollander/actions-comment-pull-request@fabd468d3a1a0b97feee5f6b9e499eab0dd903f6
uses: thollander/actions-comment-pull-request@e2c37e53a7d2227b61585343765f73a9ca57eda9
with:
message: |
:arrow_right: **PR build request submitted to `test-main-pipeline`** :arrow_left:
Expand Down
10 changes: 9 additions & 1 deletion packages/@aws-cdk-testing/framework-integ/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,18 @@ See `integ-runner` package or `yarn integ --help` for detailed instructions.

## Common Errors

### Error: For this test you must provide your own HostedZoneId/HostedZoneName/DomainName
### Error: For this test you must provide your own HostedZoneId/HostedZoneName/DomainName/Certificate

Some test cases require a publicly available domain name attached to a Amazon Route 53 Hosted Zone to work.
These test cases need to add DNS records that are then retrieved via the public internet infrastructure. This can be a subdomain to an existing domain, but it must have a Hosted Zone configured and nameservers delegated to it.

If you haven't got one ready, see the [Route 53 guide](https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/CreatingHostedZone.html) to manually create a hosted zone.

Some test cases require an ACM public certificate on a publicly available domain name to work.
These test cases need a public certificate which uses DNS for domain ownership validation.

See the [AWS Certificate Manager guide](https://docs.aws.amazon.com/acm/latest/userguide/acm-public-certificates.html) to request an Amazon-Issued certificate.

AWS CDK core team members, please check our team internal docs for guidance on how to configure domains for testing.

#### How to correctly run these tests
Expand All @@ -25,12 +30,15 @@ The checked-in snapshot uses dummy values that will not deploy.

- Go to your Hosted Zone and write down the values for `HostedZoneId`, `HostedZoneName` and `DomainName`.
All values must related to the **same** Hosted Zone.
- Go to your AWS Certificate Manager and write down the ARN for the `Certificate`
The certificate should be attached to a domain name in the **same** Hosted Zone.
- In your terminal run the following commands:

```console
export HOSTED_ZONE_ID=your_hosted_zone_id
export HOSTED_ZONE_NAME=your_hosted_zone_name
export DOMAIN_NAME=your_domain_name
export CERT_ARN=your_certificate_arn
```

- Finally, in the same terminal run your specific test case with the **update workflow disabled**. For example:
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 9e573e0

Please sign in to comment.