Skip to content

Commit

Permalink
chore(cli): fix bootstrap v2 by adding a missing 'await' (#7087)
Browse files Browse the repository at this point in the history
The title says it all.

Q: Why wasn't this caught in testing/why didn't you add a test?

A: We had tests on this originally, but we reverted them because
they made assumptions on the source environment and would fail
when run in the pipeline. Restoring those is next on the agenda.

2e9f241
  • Loading branch information
rix0rrr authored Mar 31, 2020
1 parent bded683 commit 934d58e
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export async function bootstrapEnvironment2(environment: cxapi.Environment, sdk:
// convert from YAML to JSON (which the Cloud Assembly uses)
const templateFile = `${toolkitStackName}.template.json`;
const bootstrapTemplatePath = path.join(__dirname, 'bootstrap-template.yaml');
const bootstrapTemplateObject = loadStructuredFile(bootstrapTemplatePath);
const bootstrapTemplateObject = await loadStructuredFile(bootstrapTemplatePath);
await fs.writeJson(
path.join(builder.outdir, templateFile),
bootstrapTemplateObject);
Expand Down

0 comments on commit 934d58e

Please sign in to comment.