Skip to content

Commit

Permalink
fix(events-targets): hardcoded AWS partition in ECS task resource ARN (
Browse files Browse the repository at this point in the history
…#29633)

### Issue # (if applicable)

Closes #29610 

Related to #28898

### Reason for this change

Previously the AWS partition was hardcoded so it would not work for other special partitions.

### Description of changes

Replace hardcoded `aws` partition to be dynamically added with `this.cluster.stack.partition`. 

### Description of how you validated changes

Ran integ tests suite, no changes. 

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
paulhcsun authored Mar 27, 2024
1 parent b54f959 commit 69cff2e
Show file tree
Hide file tree
Showing 21 changed files with 786 additions and 739 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -918,7 +918,11 @@
"Fn::Join": [
"",
[
"arn:aws:ecs:",
"arn:",
{
"Ref": "AWS::Partition"
},
":ecs:",
{
"Ref": "AWS::Region"
},
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 69cff2e

Please sign in to comment.