Merge branch 'main' into modify_item_reader

aws · Oct 14, 2024 · 6395bd0 · 6395bd0
2 parents 7463bc4 + f4f8abc
commit 6395bd0
Show file tree

Hide file tree

Showing 43 changed files with 9,781 additions and 59 deletions.
diff --git a/packages/@aws-cdk-testing/framework-integ/README.md b/packages/@aws-cdk-testing/framework-integ/README.md
@@ -6,13 +6,18 @@ See `integ-runner` package or `yarn integ --help` for detailed instructions.
 
 ## Common Errors
 
-### Error: For this test you must provide your own HostedZoneId/HostedZoneName/DomainName
+### Error: For this test you must provide your own HostedZoneId/HostedZoneName/DomainName/Certificate
 
 Some test cases require a publicly available domain name attached to a Amazon Route 53 Hosted Zone to work.
 These test cases need to add DNS records that are then retrieved via the public internet infrastructure. This can be a subdomain to an existing domain, but it must have a Hosted Zone configured and nameservers delegated to it.
 
 If you haven't got one ready, see the [Route 53 guide](https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/CreatingHostedZone.html) to manually create a hosted zone.
 
+Some test cases require an ACM public certificate on a publicly available domain name to work.
+These test cases need a public certificate which uses DNS for domain ownership validation.
+
+See the [AWS Certificate Manager guide](https://docs.aws.amazon.com/acm/latest/userguide/acm-public-certificates.html) to request an Amazon-Issued certificate.
+
 AWS CDK core team members, please check our team internal docs for guidance on how to configure domains for testing.
 
 #### How to correctly run these tests
@@ -25,12 +30,15 @@ The checked-in snapshot uses dummy values that will not deploy.
 
 - Go to your Hosted Zone and write down the values for `HostedZoneId`, `HostedZoneName` and `DomainName`.
    All values must related to the **same** Hosted Zone.
+- Go to your AWS Certificate Manager and write down the ARN for the `Certificate`
+   The certificate should be attached to a domain name in the **same** Hosted Zone.
 - In your terminal run the following commands:
 
 ```console
 export HOSTED_ZONE_ID=your_hosted_zone_id
 export HOSTED_ZONE_NAME=your_hosted_zone_name
 export DOMAIN_NAME=your_domain_name
+export CERT_ARN=your_certificate_arn
 ```
 
 - Finally, in the same terminal run your specific test case with the **update workflow disabled**. For example:

diff --git a/.../asset.bde7b5c89cb43285f884c94f0b9e17cdb0f5eb5345005114dd60342e0b8a85a1/__entrypoint__.js b/.../asset.bde7b5c89cb43285f884c94f0b9e17cdb0f5eb5345005114dd60342e0b8a85a1/__entrypoint__.js
diff --git a/....snapshot/asset.bde7b5c89cb43285f884c94f0b9e17cdb0f5eb5345005114dd60342e0b8a85a1/index.js b/....snapshot/asset.bde7b5c89cb43285f884c94f0b9e17cdb0f5eb5345005114dd60342e0b8a85a1/index.js
diff --git a/...aws-ecs-patterns/test/ec2/integ.tls-network-load-balanced-ecs-service.js.snapshot/cdk.out b/...aws-ecs-patterns/test/ec2/integ.tls-network-load-balanced-ecs-service.js.snapshot/cdk.out
diff --git a/...-ecs-patterns/test/ec2/integ.tls-network-load-balanced-ecs-service.js.snapshot/integ.json b/...-ecs-patterns/test/ec2/integ.tls-network-load-balanced-ecs-service.js.snapshot/integ.json