Skip to content

Commit

Permalink
fix: align IRepository events to RepositoryBase
Browse files Browse the repository at this point in the history
Options are now not required in `onXxx` methods, but IRepository
was not updated to that end.

Related #2921
  • Loading branch information
Elad Ben-Israel committed Jun 24, 2019
1 parent e537e4c commit 5862f38
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/@aws-cdk/aws-ecr/lib/repository.ts
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export interface IRepository extends IResource {
* @param id The id of the rule
* @param options Options for adding the rule
*/
onCloudTrailEvent(id: string, options: events.OnEventOptions): events.Rule;
onCloudTrailEvent(id: string, options?: events.OnEventOptions): events.Rule;

/**
* Defines an AWS CloudWatch event rule that can trigger a target when an image is pushed to this
Expand All @@ -79,7 +79,7 @@ export interface IRepository extends IResource {
* @param id The id of the rule
* @param options Options for adding the rule
*/
onCloudTrailImagePushed(id: string, options: OnCloudTrailImagePushedOptions): events.Rule;
onCloudTrailImagePushed(id: string, options?: OnCloudTrailImagePushedOptions): events.Rule;
}

/**
Expand Down

0 comments on commit 5862f38

Please sign in to comment.