Skip to content

Commit

Permalink
chore(cli): correctly install dependencies in integ tests after refac…
Browse files Browse the repository at this point in the history
…tor (#12029)

The changes from #11595 moved some helper TypeScript files around.
When running without compiling first (like in the pipeline, or in the canaries),
we need to install the dependencies those files need manually.
Unfortunately, after the move, they are now installed in a sibling directory,
not in any ancestor directory,
and so `require`ing them fails.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
skinny85 authored Dec 11, 2020
1 parent 092373a commit 56886d0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions packages/aws-cdk/.npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ tsconfig.json
!lib/init-templates/**/jest.config.js

!test/integ/cli/jest.config.js
!test/integ/uberpackage/jest.config.js
!test/integ/cli-regression-patches/**/*

.DS_Store
Expand Down
2 changes: 1 addition & 1 deletion packages/aws-cdk/test/integ/common/jest-test.bash
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ function invokeJest() {
# package.json.
if ! npx --no-install jest --version; then
echo 'Looks like we need to install jest first. Hold on.' >& 2
npm install --prefix . jest jest-junit aws-sdk
npm install --prefix .. jest jest-junit aws-sdk
fi

# This must --runInBand because parallelism is arranged for inside the tests
Expand Down

0 comments on commit 56886d0

Please sign in to comment.