Skip to content

Commit

Permalink
fix(cloudformation-diff): move aws-sdk to dependency for cfn-diff to …
Browse files Browse the repository at this point in the history
…get CFN types resolved in exports (#28768)

Issue still persists after #28680. 
```
node_modules/@aws-cdk/cloudformation-diff/lib/diff-template.d.ts:1:37 - error TS2307: Cannot find module 'aws-sdk' or its corresponding type declarations.

1 import type { CloudFormation } from 'aws-sdk';
                                      ~~~~~~~~~


Found 1 error in node_modules/@aws-cdk/cloudformation-diff/lib/diff-template.d.ts:1
```

Types are still required as a direct dependency in package.json.

Closes #28679 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
frankpengau authored Mar 16, 2024
1 parent 507b709 commit 28c4be3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/@aws-cdk/cloudformation-diff/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
"dependencies": {
"@aws-cdk/aws-service-spec": "^0.0.53",
"@aws-cdk/service-spec-types": "^0.0.53",
"aws-sdk": "2.1576.0",
"chalk": "^4",
"diff": "^5.2.0",
"fast-deep-equal": "^3.1.3",
Expand All @@ -38,7 +39,6 @@
"@types/string-width": "^4.0.1",
"fast-check": "^3.16.0",
"jest": "^29.7.0",
"aws-sdk": "2.1576.0",
"ts-jest": "^29.1.2"
},
"repository": {
Expand Down

0 comments on commit 28c4be3

Please sign in to comment.