Skip to content

Commit

Permalink
chore: include RELEASE_NOTES in packed distribution (#17118)
Browse files Browse the repository at this point in the history
We now create and generate a `RELEASE_NOTES.md` file as part of our build, with
the intent to use it for our GitHub release publishing. See (#16942) and
cdklabs/aws-delivlib#1044.

What I missed is that after the build, we pack, and then only include what ends
up in `./dist` in the final build artifact that goes to publishing. This fix
includes the release notes in the dist folder so it will be picked up and used
by the release process.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
njlynch authored Oct 22, 2021
1 parent c74b012 commit 260df31
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pack.sh
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,9 @@ cat > ${distdir}/build.json <<HERE
}
HERE

# copy CHANGELOG.md to dist/ for github releases
# copy CHANGELOG.md and RELEASE_NOTES.md to dist/ for github releases
cp ${changelog_file} ${distdir}/CHANGELOG.md
cp RELEASE_NOTES.md ${distdir}/RELEASE_NOTES.md

# defensive: make sure our artifacts don't use the version marker (this means
# that "pack" will always fails when building in a dev environment)
Expand Down

0 comments on commit 260df31

Please sign in to comment.