revert: "chore(ecs): clarify it's possible to use image digest on fro…

…mEcrRepository" (#27143) Reverts #27115 Renaming `tag` prop to `tagOrDigest` of the `ContainerImage.fromEcrRepository` function introduces a breaking change, not for typescript users, but for other languages that require specifying the property name when calling the function.
aws · Sep 14, 2023 · 049153e · 049153e
1 parent e6322aa
commit 049153e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/packages/@aws-cdk/aws-sagemaker-alpha/lib/container-image.ts b/packages/@aws-cdk/aws-sagemaker-alpha/lib/container-image.ts
@@ -26,12 +26,9 @@ export interface ContainerImageConfig {
 export abstract class ContainerImage {
   /**
    * Reference an image in an ECR repository
-   *
-   * @param repository ECR repository
-   * @param tagOrDigest Optional image tag or digest (digests must start with `sha256:`)
    */
-  public static fromEcrRepository(repository: ecr.IRepository, tagOrDigest: string = 'latest'): ContainerImage {
-    return new EcrImage(repository, tagOrDigest);
+  public static fromEcrRepository(repository: ecr.IRepository, tag: string = 'latest'): ContainerImage {
+    return new EcrImage(repository, tag);
   }
 
   /**

diff --git a/packages/aws-cdk-lib/aws-ecs/lib/container-image.ts b/packages/aws-cdk-lib/aws-ecs/lib/container-image.ts
@@ -18,12 +18,9 @@ export abstract class ContainerImage {
 
   /**
    * Reference an image in an ECR repository
-   *
-   * @param repository ECR repository
-   * @param tagOrDigest Optional image tag or digest (digests must start with `sha256:`)
    */
-  public static fromEcrRepository(repository: ecr.IRepository, tagOrDigest: string = 'latest') {
-    return new EcrImage(repository, tagOrDigest);
+  public static fromEcrRepository(repository: ecr.IRepository, tag: string = 'latest') {
+    return new EcrImage(repository, tag);
   }
 
   /**