Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rfc 79: cdkv2.0 - release & versioning #251

Merged
merged 9 commits into from
Sep 25, 2020
Merged

rfc 79: cdkv2.0 - release & versioning #251

merged 9 commits into from
Sep 25, 2020

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented Sep 21, 2020 •
edited
Loading

Changes:

  • Added separate section for name of the monopackage and versioning scheme during alpha and developer preview phases.

Rendered version

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache-2.0 license

@nija-at nija-at added the pr/do-not-merge Let mergify know not to auto merge label Sep 21, 2020
@nija-at nija-at self-assigned this Sep 21, 2020
eladb
eladb reviewed Sep 21, 2020
View reviewed changes
text/0079-cdk-2.0.md Outdated Show resolved Hide resolved
@nija-at nija-at requested a review from a team September 21, 2020 14:09
@nija-at nija-at marked this pull request as ready for review September 21, 2020 14:09
RomainMuller
RomainMuller reviewed Sep 22, 2020
View reviewed changes
text/0079-cdk-2.0.md Outdated Show resolved Hide resolved
RomainMuller
RomainMuller reviewed Sep 22, 2020
View reviewed changes
text/0079-cdk-2.0.md Outdated Show resolved Hide resolved
eladb
eladb approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@nija-at nija-at removed the pr/do-not-merge Let mergify know not to auto merge label Sep 25, 2020
@nija-at nija-at merged commit 7d06651 into master Sep 25, 2020
@nija-at nija-at deleted the nija-at/cdkv2-pkgmgr-releases branch September 25, 2020 11:21
@snyk-bot snyk-bot mentioned this pull request Apr 10, 2022
Open
@NOUIY NOUIY mentioned this pull request Oct 5, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

@RomainMuller RomainMuller Awaiting requested review from RomainMuller

Assignees

@nija-at nija-at

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nija-at @RomainMuller @eladb