Use eks:cluster-name as clusterId #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypipes
suggested changes
Mar 2, 2020
jaypipes
reviewed
Mar 3, 2020
pkg/publisher/publisher.go
Outdated
| @@ -207,6 +198,32 @@ func (p *cloudWatchPublisher) getCloudWatchMetricNamespace() *string { | |||
| return aws.String(cloudwatchMetricNamespace) | |||
| } | |||
|
|
|||
| func getClusterId(ec2Client *ec2wrapper.EC2Wrapper) string { | |||
There was a problem hiding this comment.
Tiny nit... could you name this getClusterID() (capitalized ID) please?
|
Changes in. PTAL. |
|
I just realised that I think the condition should be: |
jaypipes
approved these changes
Mar 3, 2020
|
Thanks @jaypipes Will this get merged by a collaborator automatically at some stage, or do I need to assign somebody specific? |
mogren
approved these changes
Mar 4, 2020
mogren
pushed a commit
to mogren/amazon-vpc-cni-k8s
that referenced
this pull request
Apr 20, 2020
* Use eks:cluster-name as clusterId
mogren
pushed a commit
that referenced
this pull request
Apr 20, 2020
* Use eks:cluster-name as clusterId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #775
Description of changes:
Prioritise
eks:cluster-nameas clusterId for cni-metrics-helper. This is the tag that EKS node-groups is automatically adding.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.