Test wait for update #826
Test wait for update #826
Conversation
mogren
force-pushed
the
test-wait-for-update
branch
4 times, most recently
from
14a166c
to
957fe61
Compare
mogren
force-pushed
the
test-wait-for-update
branch
from
957fe61
to
bd54907
Compare
| @@ -1,15 +1,19 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| function down-test-cluster() { | |||
| if [[ -n "${CIRCLE_JOB:-}" ]]; then | |||
There was a problem hiding this comment.
Why would you want to disable the cluster delete when running in CI?
There was a problem hiding this comment.
Just making it more verbose. See comment below.
| $TESTER_PATH eks create cluster --path $CLUSTER_CONFIG 2>> $CLUSTER_MANAGE_LOG_PATH 1>&2 || | ||
| (echo "failed. Check $CLUSTER_MANAGE_LOG_PATH." && exit 1) | ||
| echo "ok." | ||
| fi |
There was a problem hiding this comment.
I'm confused why you're changing the above depending on whether it's running in CI or not?
There was a problem hiding this comment.
It's just changing the logging output. By default, CircleCI will terminate any test after 10 minutes fi there is no console output. That can be changed by setting no_output_timeout for the job, but when you have to wait 40 minutes it's more interesting to see what is going on.
|
|
||
| echo "Sleping for 110s" | ||
| echo "TODO: Poll and wait for updates to complete instead!" | ||
| sleep 110 |
There was a problem hiding this comment.
why 110 seconds? is that a magic value? :)
There was a problem hiding this comment.
Yes, for now. The test cluster has 3 nodes, and the rolling update is using the default grace period of 30s, so it takes around 30s to shut down each node, and another 5-10 seconds to start up. It's ok to start the test once all old ipamd pods have shut down.
mogren
force-pushed
the
test-wait-for-update
branch
from
bd54907
to
42716c4
Compare
| $TESTER_PATH eks create cluster --path $CLUSTER_CONFIG 2>> $CLUSTER_MANAGE_LOG_PATH 1>&2 || | ||
| (echo "failed. Check $CLUSTER_MANAGE_LOG_PATH." && exit 1) | ||
| echo "ok." | ||
| fi |
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.