use init container for CNI setup #727
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a shell script as the entrypoint for the CNI image and relying on that shell script to copy the CNI plugin binary to a host volume, perform those steps using an initContainer and set the CNI aws-k8s-agent binary to be the CNI image's CMD. This has the benefit of not embedding setup steps in either a shell script that needs to be copied into the target image /app directory nor hard-coded into the aws-k8s-agent's main.go file (which was performing the copy of the CNI plugin binary to a host volume). See discussion in aws#706 (comment) for more details.
jaypipes
force-pushed
the
rework-build-and-init
branch
from
54ec33d
to
51eff74
Compare
|
I like the idea of having an init container, but I would also like to have the config file copied only once ipamd is up and running, so that we know there are at least a few IPs available in the subnet where the node is launched. |
|
Will need to reevaluate this one. Closing and going with a different approach. |
|
#735 contains my new approach... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a shell script as the entrypoint for the CNI image and
relying on that shell script to copy the CNI plugin binary to a host
volume, perform those steps using an initContainer and set the CNI
aws-k8s-agent binary to be the CNI image's CMD.
This has the benefit of not embedding setup steps in either a shell
script that needs to be copied into the target image /app directory nor
hard-coded into the aws-k8s-agent's main.go file (which was performing
the copy of the CNI plugin binary to a host volume).
See discussion in
#706 (comment)
for more details.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.