Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return the error from ipamd to plugin #688

Merged
merged 1 commit into from
Nov 5, 2019

Conversation

mogren
Copy link
Contributor

@mogren mogren commented Oct 29, 2019

Description of changes:

  • Returns any errors we get in ipamd back to the CNI plugin binary
  • Handle the ErrUnknownPod error in the CNI plugin binary

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mogren mogren requested review from jaypipes and nckturner November 1, 2019 22:49
Copy link
Contributor

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks good, thanks @mogren

@jaypipes jaypipes merged commit c74841a into aws:master Nov 5, 2019
@mogren mogren deleted the return-error-on-del branch November 5, 2019 18:47
mogren pushed a commit to mogren/amazon-vpc-cni-k8s that referenced this pull request Dec 15, 2019
jaypipes pushed a commit that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants