Add MTU to the plugin config #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogren
force-pushed
the
set-mtu-eth0
branch
3 times, most recently
from
16f7b42 to
3e13f7c
Compare
|
With Without setting the environment variable |
jaypipes
suggested changes
Oct 25, 2019
mogren
force-pushed
the
set-mtu-eth0
branch
2 times, most recently
from
2daee65 to
80b3df3
Compare
jaypipes
suggested changes
Oct 28, 2019
plugins/routed-eni/cni.go
Outdated
| @@ -67,6 +69,9 @@ type NetConf struct { | |||
| // veth device name. It should be no more than four characters, and | |||
| // defaults to 'eni'. | |||
| VethPrefix string `json:"vethPrefix"` | |||
|
|
|||
| // MTU for eth0 | |||
| Mtu string `json:"mtu"` | |||
There was a problem hiding this comment.
Something I noticed... but golang naming practices generally encourage acronyms to be capitalized when exported, so this really should be "MTU", not "Mtu", like "CNIVersion" is capitalized above...
See more here: https://github.com/golang/go/wiki/CodeReviewComments#initialisms
There was a problem hiding this comment.
I agree, should be all upper case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #665
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.