Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IPs to the first ENI on startup #648

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Add IPs to the first ENI on startup #648

merged 1 commit into from
Oct 9, 2019

Conversation

mogren
Copy link
Contributor

@mogren mogren commented Oct 8, 2019 •
edited
Loading

Description of changes:

  • Make sure we have IPs available before making the node ready
  • This change will add a 400 - 600ms delay before marking a node as Ready
  • For new nodes, this saves at least 2.5 seconds before IPs are available

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mogren mogren added this to the v1.6 milestone Oct 8, 2019
@mogren mogren requested review from nckturner and vsiddharth October 8, 2019 22:50
@mogren mogren force-pushed the ensure-eni0-has-ips branch 2 times, most recently from f87f732 to 778db90 Compare October 9, 2019 03:10
@jaypipes
Copy link
Contributor

jaypipes commented Oct 9, 2019

Is there an issue this is resolving/addresssing?

jaypipes
jaypipes reviewed Oct 9, 2019
View reviewed changes
ipamd/ipamd.go Outdated Show resolved Hide resolved
ipamd/ipamd.go Show resolved Hide resolved
ipamd/ipamd.go Show resolved Hide resolved
@mogren mogren force-pushed the ensure-eni0-has-ips branch from 778db90 to 98ae1e7 Compare October 9, 2019 20:48
@mogren mogren force-pushed the ensure-eni0-has-ips branch from 98ae1e7 to 2652c36 Compare October 9, 2019 22:04
jaypipes
jaypipes approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mogren mogren merged commit 8f40e8e into aws:master Oct 9, 2019
@mogren mogren deleted the ensure-eni0-has-ips branch November 5, 2019 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaypipes jaypipes jaypipes approved these changes

@nckturner nckturner Awaiting requested review from nckturner

@vsiddharth vsiddharth Awaiting requested review from vsiddharth

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.
2 participants
@mogren @jaypipes