Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log security groups correctly #646

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Log security groups correctly #646

merged 1 commit into from
Oct 16, 2019

Conversation

mogren
Copy link
Contributor

@mogren mogren commented Oct 8, 2019 •
edited
Loading

Description of changes:
Before:

[INFO] createENI: use primary interface's config, [0xc00003b680 0xc00003b6b0], subnet-0391a9d4a4d2cb999

After:

[INFO] Using same config as the primary interface for the new ENI
[INFO] Creating ENI with security groups: [sg-08f1036b507b30999 sg-0aa43d9d01804c999] in subnet: subnet-02d0c4ea9bd25d999

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

nckturner
nckturner reviewed Oct 8, 2019
View reviewed changes
pkg/awsutils/awsutils.go Outdated Show resolved Hide resolved
pkg/awsutils/awsutils.go Outdated Show resolved Hide resolved
tiffanyfay
tiffanyfay approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@tiffanyfay tiffanyfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@mogren mogren merged commit 3aacadc into aws:master Oct 16, 2019
@mogren mogren deleted the small-fix branch November 5, 2019 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nckturner nckturner nckturner left review comments

@tiffanyfay tiffanyfay tiffanyfay approved these changes

@vsiddharth vsiddharth Awaiting requested review from vsiddharth

Assignees
No one assigned
Labels
tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mogren @nckturner @tiffanyfay