Copy the binary and config after ipamd is ready #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogren
force-pushed
the
copy-files-in-go
branch
from
6e9da51 to
86e6156
Compare
Merged
micahhausler
approved these changes
Aug 7, 2019
| return 1 | ||
| } | ||
|
|
||
| log.Info("Copying /app/10-aws.conflist to /host/etc/cni/net.d/10-aws.conflist") |
There was a problem hiding this comment.
I think this is fine for now, but do we want to parameterize this filename? I'm take it or leave it
| return 0 | ||
| } | ||
|
|
||
| // copyFileContents copies a file | ||
| func copyFileContents(src, dst string) error { |
There was a problem hiding this comment.
Should we have a test for this?
There was a problem hiding this comment.
Adding in a separate PR.
This was referenced Aug 7, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #282, #575
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.