Update start script to wait for ipamd health check #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiffanyfay
reviewed
Aug 1, 2019
Wait for the ipamd health check to be SERVING before copying in the CNI binary and config file. aws#282
tiffanyfay
approved these changes
Aug 1, 2019
nithu0115
reviewed
Aug 1, 2019
|
|
||
| echo "===== Starting amazon-k8s-agent ===========" | ||
| /app/aws-k8s-agent | ||
| main |
There was a problem hiding this comment.
Even though there are no positional parameters, I personally would add main "$@"
| cp /app/10-aws.conflist /host/etc/cni/net.d/ | ||
|
|
||
| if [[ -f /host/etc/cni/net.d/aws.conf ]]; then | ||
|
|
There was a problem hiding this comment.
Probably fail fast, by adding set -eo pipefail
There was a problem hiding this comment.
Good point, will add.
|
I've been eagerly anticipating something like this. When should we expect it to show up in an official image I can start running? |
|
Issue #555 is a follow up to this PR with new release candidate image which will include these changes. |
This was referenced Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #282
Description of changes:
This is a quick fix for the release-1.5 branch. It will also add additional log lines to the aws-node stdout logs. The long term goal will probably be to move the set up into go instead and have ipamd copy the files once it's ready.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.