Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set iptables FORWARD rules ACCEPT for inside VPC traffic #535

Closed
wants to merge 2 commits into from

Conversation

Komey
Copy link

@Komey Komey commented Jul 21, 2019

Description of changes:
For some AMI doesn't ACCEPT FORWARD traffic by default, this will enable those traffic FORWARD in VPC CIDR

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mogren mogren self-requested a review July 24, 2019 22:21
@mogren
Copy link
Contributor

mogren commented Jul 31, 2019

Hi @Komey,

Could you explain the use case for this? It seems like a configuration that should belong in the AMI and not the CNI?

@Komey
Copy link
Author

Komey commented Aug 2, 2019

Hi @Komey,

Could you explain the use case for this? It seems like a configuration that should belong in the AMI and not the CNI?

Hi @mogren

I was testing a self-hosted k8s cluster with AMI --> ubuntu/images/hvm-ssd/ubuntu-bionic-18.04-amd64-server-20190212.1 (ami-0c55b159cbfafe1f0) , which is not accept forward traffic in any cidr.
In my opinion, It will be better that CNI take care of the traffic which has been configured within the VPC cird

@mogren
Copy link
Contributor

mogren commented Apr 29, 2020

The reason we do it outside the CNI is that this applies outside of Kubernetes as well, for example if you have Docker containers running on an EC2 instance.

@mogren mogren closed this Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants