Update kubeconfig lookup order for eksctl nodegroups #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During eksctl bootstrap, the `/etc/systemd/system/kubelet.service` file still exists, although `kubelet.service.d/10-eksclt.al2.conf` and `/etc/eksctl/kubeconfig.yaml` are created and used. This causes errors when running the `aws-cni-support.sh` script due to the precedence of looking up the kubeconfig file. `error: unable to read certificate-authority /etc/kubernetes/pki/ca.crt for kubernetes due to open /etc/kubernetes/pki/ca.crt: no such file or directory`
mogren
approved these changes
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During eksctl bootstrap, the
/etc/systemd/system/kubelet.servicefile still exists, althoughkubelet.service.d/10-eksclt.al2.confand/etc/eksctl/kubeconfig.yamlare created and used [1].This causes errors when running the
aws-cni-support.shscript due to the precedence of looking up the kubeconfig file.error: unable to read certificate-authority /etc/kubernetes/pki/ca.crt for kubernetes due to open /etc/kubernetes/pki/ca.crt: no such file or directory[1] https://github.com/weaveworks/eksctl/blob/master/pkg/nodebootstrap/userdata_al2.go
Issue #, if available:
Description of changes:
Reversed the lookup to first match eksctl bootstrapped nodes to avoid errors retrieving introspection data.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.