-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add env var to override introspection bind address #501
Conversation
I have added another commit which changes the default back because the introspection endpoint is largely useless when bound to localhost. |
@jacksontj Hi, the prometheus metrics port has not changed, it was just moved to another file: ipamd/metrics.go. You can still query PR #433 moved the introspection endpoint that returns data in json format and that is used for debugging the CNI's internal state to another port and bound it to localhost: ipamd/introspect.go. The debug script was updated to handle this. Are there some additional metrics that you are missing that can only be found through the introspection endpoints? |
8b48c9d
to
7756375
Compare
@mogren OIC, it changed the The bind interface for this introspection endpoint was still changed without mention in the release notes. I'll remove the patch to change the default back, but I still think it would be good to add the env variable override -- but it isn't a huge blocker for my specific use-case |
2b08772 (inadvertently?) changed the bind address from `:61678` to `localhost:61678` which is backwards incompatible and for those actually scraping the metrics via prometheus makes the metrics endpoint entirely unusable (since prometheus isn't local to each node in the cluster). This path simply adds an env var to override the bind address.
7756375
to
bcc21ae
Compare
I also just added the new env var to README (apparently I missed that in the previous commit). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
2b08772 (inadvertently?) changed the
bind address from
:61678
tolocalhost:61678
which is backwardsincompatible and for those actually scraping the metrics via prometheus
makes the metrics endpoint entirely unusable (since prometheus isn't
local to each node in the cluster).
This path simply adds an env var to override the bind address.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.