Add IPs to existing ENIs first #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogren
force-pushed
the
add-ips-first
branch
2 times, most recently
from
dec9dc9 to
ee2eaa1
Compare
nckturner
reviewed
May 28, 2019
There was a problem hiding this comment.
When WARM_IP_TARGET is set, try to allocate that many IPs on the current ENI before allocating a new ENI.
As discussed offline, the problem is at low values of WARM_IP_TARGET, scaling up becomes excruciatingly slow. Perhaps we can try to allocate the full ENI, but if that fails, we can attempt to allocate using progressively smaller step sizes.
tiffanyfay
reviewed
May 29, 2019
tiffanyfay
reviewed
May 29, 2019
tiffanyfay
reviewed
May 29, 2019
tiffanyfay
reviewed
May 29, 2019
If that fails, try to just add 1 IP to the ENI
tiffanyfay
approved these changes
May 29, 2019
nckturner
approved these changes
May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
WARM_IP_TARGETis set, try to allocate all unallocated IPs for the current ENI. If that fails, try to just add1IP to an existing ENI before allocating a new ENI.currentMaxAddrsPerENIsince it will not change.customNetworkCfgonceBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.