Moved all GetEnv's calls to init step

[Zyqsempai]

Issue #419

Description of changes: Moved all GetEnv's calls to init step

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[nckturner]

Thanks for this cleanup! Can you just fix the unit test:

== RUN   TestGetWarmIPTargetState
--- FAIL: TestGetWarmIPTargetState (0.00s)
    ipamd_test.go:404: 
        	Error Trace:	ipamd_test.go:404
        	Error:      	Should be true
        	Test:       	TestGetWarmIPTargetState
    ipamd_test.go:405: 
        	Error Trace:	ipamd_test.go:405
        	Error:      	Not equal: 
        	            	expected: 5
        	            	actual  : 0
        	Test:       	TestGetWarmIPTargetState
    ipamd_test.go:414: 
        	Error Trace:	ipamd_test.go:414
        	Error:      	Should be true
        	Test:       	TestGetWarmIPTargetState
    ipamd_test.go:415: 
        	Error Trace:	ipamd_test.go:415
        	Error:      	Not equal: 
        	            	expected: 3
        	            	actual  : 0
        	Test:       	TestGetWarmIPTargetState
    ipamd_test.go:424: 
        	Error Trace:	ipamd_test.go:424
        	Error:      	Should be true
        	Test:       	TestGetWarmIPTargetState

[Zyqsempai]

@nckturner Hey, I have some troubles with running tests locally, so I can't see why do they failing now. Can you help me with that?

[mogren]

@Zyqsempai Are you running on a Mac? If you have docker installed, make docker-unit-test should work.

[Zyqsempai]

@mogren yes on MAC, thank you it helped, but I still have the same test report as in the Travis, not enought detailed, can i make it more verbose to get something similar to what @nckturner sent above?

[Zyqsempai]

@nckturner @mogren PTAL

[nckturner]

So it looks like you basically removed testIncreaseIPPool(), which I don't disagree with because I'm not a fan of most of the unit tests on this project. They basically test a whole bunch of implementation details and I think we'd be hard pressed to find much value in them. Considering we have some work going into integration testing right now, should we remove this test and consider refactoring and adding it back in a separate PR @mogren?

[Zyqsempai]

@mogren PTAL

[mogren]

Sorry for all the back and forth, but this is a pretty important change. Thanks for fixing the issue, almost done!

[Zyqsempai]

@mogren Done;) Thank you for your help!

[mogren]

Thanks, looks good to me!