Remove globalfelixconfigs and globalbgpconfigs from calico config #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tiffanyfay @mogren I think I led you guys in the wrong direction on this one, it turns out the new code does in fact check for this as part of the migration code. It doesn't need the CRD to exist, but it needs the permission otherwise it will fail. We should probably fix upstream in Calico so that it doens't need this any more, but for now I think we'll need to revert this change... Sorry for the runaround. |
|
Thanks @caseydavenport, I agree this seem to cause an issue. We will revert the change for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Removed globalfelixconfigs and globalbgpconfigs from calico config following conversation #406 (comment)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.