Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): add volume mount for docker-func-test target #3160

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

omerap12
Copy link
Contributor

What type of PR is this?
/kind bug

Which issue does this PR fix?:
fixes: #3076

What does this PR do / Why do we need it?:
The docker-func-test Make target fails because it cannot access /host/opt/cni/bin
directory which is expected to be mounted from the host system.

Testing done on this change:

Will this PR introduce any new dependencies?:
NONE

Will this break upgrades or downgrades? Has updating a running cluster been tested?:
NONE

Does this change require updates to the CNI daemonset config files to work?:
NONE

Does this PR introduce any user-facing change?:

NONE

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@omerap12 omerap12 requested a review from a team as a code owner December 23, 2024 18:49
Copy link
Member

@orsenthil orsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

But looks like this test will need to removed as it was probably written when we had full build base image. Right now, it will exercise if container can be run, and since the entrypoint is a daemon, it wont exit.

@orsenthil orsenthil merged commit 4ee9789 into aws:master Dec 25, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make docker-func-test fails on master
2 participants